Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-14 Thread Borislav Petkov
On Wed, Nov 14, 2018 at 02:59:54PM +0800, wang.y...@zte.com.cn wrote: > make allyesconfig; make W=1 arch/x86/kernel > make: Nothing to be done for `arch/x86/kernel' make allyesconfig; make W=1 arch/x86/kernel/ Note the trailing "/" -- Regards/Gruss, Boris. Good mailing practices for 400:

Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-14 Thread Borislav Petkov
On Wed, Nov 14, 2018 at 02:59:54PM +0800, wang.y...@zte.com.cn wrote: > make allyesconfig; make W=1 arch/x86/kernel > make: Nothing to be done for `arch/x86/kernel' make allyesconfig; make W=1 arch/x86/kernel/ Note the trailing "/" -- Regards/Gruss, Boris. Good mailing practices for 400:

Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-13 Thread Borislav Petkov
On Tue, Nov 13, 2018 at 07:31:44PM +0800, wang.y...@zte.com.cn wrote: > I thought this can keep patches dependent and can be reverted easily if one > of them has something wrong. Same thing with per-directory or subsystem - just less granulary. > Thanks for your suggestion, I will do as you

Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-13 Thread Borislav Petkov
On Tue, Nov 13, 2018 at 07:31:44PM +0800, wang.y...@zte.com.cn wrote: > I thought this can keep patches dependent and can be reverted easily if one > of them has something wrong. Same thing with per-directory or subsystem - just less granulary. > Thanks for your suggestion, I will do as you

Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-13 Thread Borislav Petkov
On Tue, Nov 13, 2018 at 09:56:29AM +0800, Yi Wang wrote: > We get a warning when building kernel with W=1: > arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for > ‘init_IRQ’ [-Wmissing-prototypes] > void __init init_IRQ(void) > ^ > > Add the missing declaration in

Re: [PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-13 Thread Borislav Petkov
On Tue, Nov 13, 2018 at 09:56:29AM +0800, Yi Wang wrote: > We get a warning when building kernel with W=1: > arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for > ‘init_IRQ’ [-Wmissing-prototypes] > void __init init_IRQ(void) > ^ > > Add the missing declaration in

[PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-12 Thread Yi Wang
We get a warning when building kernel with W=1: arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes] void __init init_IRQ(void) ^ Add the missing declaration in head file to fix this. Signed-off-by: Yi Wang ---

[PATCH] x86/irq: Fix -Wmissing-prototypes warning for init_IRQ()

2018-11-12 Thread Yi Wang
We get a warning when building kernel with W=1: arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes] void __init init_IRQ(void) ^ Add the missing declaration in head file to fix this. Signed-off-by: Yi Wang ---