Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

2019-02-12 Thread Jim Mattson
On Tue, Feb 12, 2019 at 6:16 AM Paolo Bonzini wrote: > > On 07/02/19 22:17, Jim Mattson wrote: > >> SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If > >> (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that > >> some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40

Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

2019-02-12 Thread Paolo Bonzini
On 07/02/19 22:17, Jim Mattson wrote: >> SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If >> (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that >> some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6, >> model: 0xf, stepping: 0x6") don't have it.

Re: [PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

2019-02-07 Thread Jim Mattson
On Thu, Feb 7, 2019 at 2:42 AM Vitaly Kuznetsov wrote: > > SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If > (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that > some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6, > model: 0xf, stepping: 0x6")

[PATCH] x86/kvm/nVMX: read from MSR_IA32_VMX_PROCBASED_CTLS2 only when it is available

2019-02-07 Thread Vitaly Kuznetsov
SDM says MSR_IA32_VMX_PROCBASED_CTLS2 is only available "If (CPUID.01H:ECX.[5] && IA32_VMX_PROCBASED_CTLS[63])". It was found that some old cpus (namely "Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz (family: 0x6, model: 0xf, stepping: 0x6") don't have it. Add the missing check. Reported-by: Zdenek Kaspar