Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-15 Thread Wanpeng Li
On Sat, 13 Mar 2021 at 17:33, Paolo Bonzini wrote: > > On 13/03/21 01:57, Wanpeng Li wrote: > >> A third option would be to split the paths. In the end, it's only the > >> ptr/val > >> line that's shared. > > I just sent out a formal patch for my alternative fix, I think the > > whole logic in

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-13 Thread Paolo Bonzini
On 13/03/21 01:57, Wanpeng Li wrote: A third option would be to split the paths. In the end, it's only the ptr/val line that's shared. I just sent out a formal patch for my alternative fix, I think the whole logic in kvm_wait is more clear w/ my version. I don't know, having three "if"s in

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-12 Thread Wanpeng Li
On Thu, 11 Mar 2021 at 23:54, Sean Christopherson wrote: > > On Tue, Feb 23, 2021, Wanpeng Li wrote: > > On Tue, 23 Feb 2021 at 13:25, Wanpeng Li wrote: > > > > > > From: Wanpeng Li > > > > > > After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the > > > guest > > >

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-11 Thread Paolo Bonzini
On 11/03/21 16:54, Sean Christopherson wrote: On Tue, Feb 23, 2021, Wanpeng Li wrote: On Tue, 23 Feb 2021 at 13:25, Wanpeng Li wrote: From: Wanpeng Li After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the guest splatting below during boot: raw_local_irq_restore()

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-11 Thread Sean Christopherson
On Tue, Feb 23, 2021, Wanpeng Li wrote: > On Tue, 23 Feb 2021 at 13:25, Wanpeng Li wrote: > > > > From: Wanpeng Li > > > > After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the > > guest > > splatting below during boot: > > > > raw_local_irq_restore() called with IRQs

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-03-10 Thread Wanpeng Li
ping, On Tue, 23 Feb 2021 at 13:25, Wanpeng Li wrote: > > From: Wanpeng Li > > After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the > guest > splatting below during boot: > > raw_local_irq_restore() called with IRQs enabled > WARNING: CPU: 1 PID: 169 at

Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-02-22 Thread Wanpeng Li
On Tue, 23 Feb 2021 at 13:25, Wanpeng Li wrote: > > From: Wanpeng Li > > After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the > guest > splatting below during boot: > > raw_local_irq_restore() called with IRQs enabled > WARNING: CPU: 1 PID: 169 at

[PATCH] x86/kvm: Fix broken irq restoration in kvm_wait

2021-02-22 Thread Wanpeng Li
From: Wanpeng Li After commit 997acaf6b4b59c (lockdep: report broken irq restoration), the guest splatting below during boot: raw_local_irq_restore() called with IRQs enabled WARNING: CPU: 1 PID: 169 at kernel/locking/irqflag-debug.c:10 warn_bogus_irq_restore+0x26/0x30 Modules linked in: