Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-25 Thread Ingo Molnar
* Denys Vlasenko wrote: > On 08/24/2015 08:50 AM, Ingo Molnar wrote: > > > > * Ingo Molnar wrote: > > > >> > >> * Denys Vlasenko wrote: > >> > >>> I propose the table to be commented like shown below: > >>> > >>> /*Opcode: d8 d9da db dc dd de df */ >

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-25 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: On 08/24/2015 08:50 AM, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: * Denys Vlasenko dvlas...@redhat.com wrote: I propose the table to be commented like shown below: /*Opcode: d8 d9da db dc

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Denys Vlasenko
On 08/24/2015 08:50 AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> >> * Denys Vlasenko wrote: >> >>> I propose the table to be commented like shown below: >>> >>> /*Opcode: d8 d9da db dc dd de df */ >>> /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Denys Vlasenko wrote: > > > I propose the table to be commented like shown below: > > > > /*Opcode: d8 d9da db dc dd de df */ > > /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, > > _df_c0_, > >

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Ingo Molnar
* Denys Vlasenko wrote: > I propose the table to be commented like shown below: > > /*Opcode: d8 d9da db dc dd de df */ > /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, _df_c0_, > /*c8..f*/ fmul__, fxch_i, fcmove, fcmovne, fmul_i,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Denys Vlasenko
On 08/24/2015 08:50 AM, Ingo Molnar wrote: * Ingo Molnar mi...@kernel.org wrote: * Denys Vlasenko dvlas...@redhat.com wrote: I propose the table to be commented like shown below: /*Opcode: d8 d9da db dc dd de df */ /*c0..f*/ fadd__, fld_i_,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Ingo Molnar
* Ingo Molnar mi...@kernel.org wrote: * Denys Vlasenko dvlas...@redhat.com wrote: I propose the table to be commented like shown below: /*Opcode: d8 d9da db dc dd de df */ /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-24 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: I propose the table to be commented like shown below: /*Opcode: d8 d9da db dc dd de df */ /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, _df_c0_, /*c8..f*/ fmul__, fxch_i, fcmove,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-23 Thread Denys Vlasenko
On 08/23/2015 08:15 AM, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > >>> static FUNC const st_instr_table[64] = { >>> - fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, >>> _df_c0_, >>> - fmul__, fxch_i, fcmove, fcmovne, fmul_i, _dd_c8_, fmulp_, >>> _df_c8_,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-23 Thread Ingo Molnar
* Denys Vlasenko wrote: > > static FUNC const st_instr_table[64] = { > > - fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, > > _df_c0_, > > - fmul__, fxch_i, fcmove, fcmovne, fmul_i, _dd_c8_, fmulp_, > > _df_c8_, > > - fcom_st, fp_nop, fcmovbe, fcmovnbe,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-23 Thread Denys Vlasenko
On 08/23/2015 08:15 AM, Ingo Molnar wrote: * Denys Vlasenko dvlas...@redhat.com wrote: static FUNC const st_instr_table[64] = { - fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, _df_c0_, - fmul__, fxch_i, fcmove, fcmovne, fmul_i, _dd_c8_, fmulp_, _df_c8_,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-23 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: static FUNC const st_instr_table[64] = { - fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, _df_c0_, - fmul__, fxch_i, fcmove, fcmovne, fmul_i, _dd_c8_, fmulp_, _df_c8_, - fcom_st, fp_nop, fcmovbe,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Denys Vlasenko
On 08/22/2015 10:54 AM, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > >> +/* fcmovCC and f(u)comi(p) are enabled if CPUID(1).EDX(15) "cmov" is set */ >> + >> static FUNC const st_instr_table[64] = { >> -fadd__, fld_i_, __BAD__, __BAD__, fadd_i, ffree_, faddp_, _df_c0_, >> -fmul__,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Ingo Molnar
* Denys Vlasenko wrote: > +/* fcmovCC and f(u)comi(p) are enabled if CPUID(1).EDX(15) "cmov" is set */ > + > static FUNC const st_instr_table[64] = { > - fadd__, fld_i_, __BAD__, __BAD__, fadd_i, ffree_, faddp_, _df_c0_, > - fmul__, fxch_i, __BAD__, __BAD__, fmul_i, _dd_c8_, fmulp_,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Ingo Molnar
* Denys Vlasenko wrote: > Only compile-tested. > > Signed-off-by: Denys Vlasenko > CC: Ingo Molnar > CC: Borislav Petkov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Kees Cook > CC: x...@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/math-emu/fpu_aux.c | 70

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: +/* fcmovCC and f(u)comi(p) are enabled if CPUID(1).EDX(15) cmov is set */ + static FUNC const st_instr_table[64] = { - fadd__, fld_i_, __BAD__, __BAD__, fadd_i, ffree_, faddp_, _df_c0_, - fmul__, fxch_i, __BAD__, __BAD__, fmul_i,

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Ingo Molnar
* Denys Vlasenko dvlas...@redhat.com wrote: Only compile-tested. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Ingo Molnar mi...@kernel.org CC: Borislav Petkov b...@alien8.de CC: H. Peter Anvin h...@zytor.com CC: Andy Lutomirski l...@amacapital.net CC: Kees Cook

Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-22 Thread Denys Vlasenko
On 08/22/2015 10:54 AM, Ingo Molnar wrote: * Denys Vlasenko dvlas...@redhat.com wrote: +/* fcmovCC and f(u)comi(p) are enabled if CPUID(1).EDX(15) cmov is set */ + static FUNC const st_instr_table[64] = { -fadd__, fld_i_, __BAD__, __BAD__, fadd_i, ffree_, faddp_, _df_c0_, -

[PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-21 Thread Denys Vlasenko
Only compile-tested. Signed-off-by: Denys Vlasenko CC: Ingo Molnar CC: Borislav Petkov CC: "H. Peter Anvin" CC: Andy Lutomirski CC: Kees Cook CC: x...@kernel.org CC: linux-kernel@vger.kernel.org --- arch/x86/math-emu/fpu_aux.c | 70 ++ arch/x86/math-emu/fpu_entry.c

[PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns

2015-08-21 Thread Denys Vlasenko
Only compile-tested. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Ingo Molnar mi...@kernel.org CC: Borislav Petkov b...@alien8.de CC: H. Peter Anvin h...@zytor.com CC: Andy Lutomirski l...@amacapital.net CC: Kees Cook keesc...@chromium.org CC: x...@kernel.org CC: