Re: [PATCH] x86/mce: Initialize "bank" when we find a fatal error in mce_no_way_out()

On Fri, Feb 01, 2019 at 10:36:17AM -0800, Luck, Tony wrote: > > so it'll be more robust if we moved it there. > > It would be redundant to move it there for both > existing uses. Maybe. But if the bank write happens there, it won't be "forgotten" again. I don't care what the functions are

Re: [PATCH] x86/mce: Initialize "bank" when we find a fatal error in mce_no_way_out()

On Fri, Feb 01, 2019 at 10:55:53AM +0100, Borislav Petkov wrote: > On Thu, Jan 31, 2019 at 04:33:41PM -0800, Tony Luck wrote: > > if (mce_severity(m, mca_cfg.tolerant, , true) >= > > MCE_PANIC_SEVERITY) { > > + m->bank = i; > > So conceptually this write belongs

Re: [PATCH] x86/mce: Initialize "bank" when we find a fatal error in mce_no_way_out()

On Thu, Jan 31, 2019 at 04:33:41PM -0800, Tony Luck wrote: > Internal injection testing crashed with a console log that said: > > mce: [Hardware Error]: CPU 7: Machine Check Exception: f Bank 0: > bd8000100134 > > This caused a lot of head scratching because the MCACOD (bits 15:0) of that >

[PATCH] x86/mce: Initialize "bank" when we find a fatal error in mce_no_way_out()

Internal injection testing crashed with a console log that said: mce: [Hardware Error]: CPU 7: Machine Check Exception: f Bank 0: bd8000100134 This caused a lot of head scratching because the MCACOD (bits 15:0) of that status is a signature from an L1 data cache error. But Linux says that