Re: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-10 Thread Borislav Petkov
On Tue, Jul 10, 2012 at 10:12:17AM -0700, Tony Luck wrote: > On Tue, Jul 10, 2012 at 8:44 AM, Borislav Petkov wrote: > > Acked-by: Borislav Petkov > > Thanks for the Ack. > > + doit = !!PageDirty(ppage) || !!(flags & MF_MUST_KILL); > > Thinking about this some more, the "!!" are redundan

Re: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-10 Thread Tony Luck
On Tue, Jul 10, 2012 at 8:44 AM, Borislav Petkov wrote: > Acked-by: Borislav Petkov Thanks for the Ack. + doit = !!PageDirty(ppage) || !!(flags & MF_MUST_KILL); Thinking about this some more, the "!!" are redundant and are an impediment to readability. We started with !!PageDirty(ppage)

Re: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-10 Thread Borislav Petkov
On Mon, Jul 09, 2012 at 01:34:36PM -0700, Tony Luck wrote: > In commit dad1743e5993f19b3d7e7bd0fb35dc45b5326626 > x86/mce: Only restart instruction after machine check recovery if it is safe > > we fixed mce_notify_process() to force a signal to the current process > if it was not restartable (R

[PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-09 Thread Tony Luck
In commit dad1743e5993f19b3d7e7bd0fb35dc45b5326626 x86/mce: Only restart instruction after machine check recovery if it is safe we fixed mce_notify_process() to force a signal to the current process if it was not restartable (RIPV bit not set in MCG_STATUS). But doing it here means that the proc

RE: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-09 Thread Luck, Tony
> This makes mi->restartable unused? It does ... but it's not what I meant ... somehow I lost the code that set MF_MUST_KILL based on mi->restartable. Doh! >> +doit = !!PageDirty(ppage) || (flags & MF_MUST_KILL) != 0; > > Maybe > >!!(flags & MF_MUST_KILL)

Re: [PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-06 Thread Borislav Petkov
On Fri, Jul 06, 2012 at 02:33:15PM -0700, Tony Luck wrote: > In commit dad1743e5993f19b3d7e7bd0fb35dc45b5326626 > x86/mce: Only restart instruction after machine check recovery if it is safe > we fixed mce_notify_process() to force a signal to the current process > if it was not restartable (RIPV

[PATCH] x86/mce: Need to let kill_proc() send signal to doomed process

2012-07-06 Thread Tony Luck
In commit dad1743e5993f19b3d7e7bd0fb35dc45b5326626 x86/mce: Only restart instruction after machine check recovery if it is safe we fixed mce_notify_process() to force a signal to the current process if it was not restartable (RIPV bit not set in MCG_STATUS). But doing it here means that the proce