Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-24 Thread Jerome Glisse
On Sat, Jun 24, 2017 at 08:45:59AM +0200, Ingo Molnar wrote: > > * Jerome Glisse wrote: > > > On Wed, Jun 07, 2017 at 09:17:06PM +0300, Kirill A. Shutemov wrote: > > > On Wed, Jun 07, 2017 at 01:38:00PM -0400, Jerome Glisse wrote: > > > > > On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shu

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-23 Thread Ingo Molnar
* Jerome Glisse wrote: > On Wed, Jun 07, 2017 at 09:17:06PM +0300, Kirill A. Shutemov wrote: > > On Wed, Jun 07, 2017 at 01:38:00PM -0400, Jerome Glisse wrote: > > > > On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shutemov wrote: > > > > > On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-23 Thread Jerome Glisse
On Wed, Jun 07, 2017 at 09:17:06PM +0300, Kirill A. Shutemov wrote: > On Wed, Jun 07, 2017 at 01:38:00PM -0400, Jerome Glisse wrote: > > > On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shutemov wrote: > > > > On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@redhat.com wrote: > > > > > From:

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread Kirill A. Shutemov
On Wed, Jun 07, 2017 at 01:38:00PM -0400, Jerome Glisse wrote: > > On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shutemov wrote: > > > On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@redhat.com wrote: > > > > From: Jérôme Glisse > > > > > > > > With commit af2cf278ef4f we no longer free p

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread Jerome Glisse
> On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shutemov wrote: > > On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > > > With commit af2cf278ef4f we no longer free pud so that we do not > > > have synchronize all pgd on hotremove/vfree. B

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread Kirill A. Shutemov
On Wed, Jun 07, 2017 at 08:03:25PM +0300, Kirill A. Shutemov wrote: > On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > With commit af2cf278ef4f we no longer free pud so that we do not > > have synchronize all pgd on hotremove/vfree. But the new 5

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread Kirill A. Shutemov
On Wed, Jun 07, 2017 at 10:46:20AM -0400, jgli...@redhat.com wrote: > From: Jérôme Glisse > > With commit af2cf278ef4f we no longer free pud so that we do not > have synchronize all pgd on hotremove/vfree. But the new 5 level > page table patchset reverted that for 4 level page table. > > This p

Re: [PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread Logan Gunthorpe
This patch still fixes my bug. Tested-by: Logan Gunthorpe Thanks, Logan On 07/06/17 08:46 AM, jgli...@redhat.com wrote: > From: Jérôme Glisse > > With commit af2cf278ef4f we no longer free pud so that we do not > have synchronize all pgd on hotremove/vfree. But the new 5 level > page table p

[PATCH] x86/mm/hotplug: fix BUG_ON() after hotremove by not freeing pud v2

2017-06-07 Thread jglisse
From: Jérôme Glisse With commit af2cf278ef4f we no longer free pud so that we do not have synchronize all pgd on hotremove/vfree. But the new 5 level page table patchset reverted that for 4 level page table. This patch restore af2cf278ef4f and disable free_pud() if we are in the 4 level page tab