Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Greg KH
On Mon, Sep 17, 2018 at 02:16:33PM +0200, Jiri Slaby wrote: > On 09/17/2018, 01:51 PM, Greg KH wrote: > > On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: > >>> And what about populate_pud? > >>> set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, > >>>

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Greg KH
On Mon, Sep 17, 2018 at 02:16:33PM +0200, Jiri Slaby wrote: > On 09/17/2018, 01:51 PM, Greg KH wrote: > > On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: > >>> And what about populate_pud? > >>> set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, > >>>

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Jiri Slaby
On 09/17/2018, 01:51 PM, Greg KH wrote: > On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: >>> And what about populate_pud? >>> set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >>>canon_pgprot(pud_pgprot; >>> >>> start

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Jiri Slaby
On 09/17/2018, 01:51 PM, Greg KH wrote: > On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: >>> And what about populate_pud? >>> set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >>>canon_pgprot(pud_pgprot; >>> >>> start

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Greg KH
On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: > > And what about populate_pud? > > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, > >canon_pgprot(pud_pgprot; > > > > start += PUD_SIZE; > >

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-17 Thread Greg KH
On Thu, Sep 06, 2018 at 01:27:49PM -0700, Andi Kleen wrote: > > And what about populate_pud? > > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, > >canon_pgprot(pud_pgprot; > > > > start += PUD_SIZE; > >

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Andi Kleen
> And what about populate_pud? > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >canon_pgprot(pud_pgprot; > > start += PUD_SIZE; > cpa->pfn += PUD_SIZE; Yes you're right. That case needs to be fixed too. Are

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Andi Kleen
> And what about populate_pud? > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >canon_pgprot(pud_pgprot; > > start += PUD_SIZE; > cpa->pfn += PUD_SIZE; Yes you're right. That case needs to be fixed too. Are

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Jiri Slaby
On 08/25/2018, 03:50 PM, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts commit

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Jiri Slaby
On 08/25/2018, 03:50 PM, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts commit

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Greg KH
On Sat, Aug 25, 2018 at 10:06:41PM -0700, Andi Kleen wrote: > > > Cc: sta...@vger.kernel.org # 4.4 and 4.9 > > > > LGTM for v4.4.y but ... are you sure that this patch applies to v4.9.y ? > > Commit edc3b9129cec is 'native' in v4.9.y and has not been reverted there. > > You're right. I thought

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Greg KH
On Sat, Aug 25, 2018 at 10:06:41PM -0700, Andi Kleen wrote: > > > Cc: sta...@vger.kernel.org # 4.4 and 4.9 > > > > LGTM for v4.4.y but ... are you sure that this patch applies to v4.9.y ? > > Commit edc3b9129cec is 'native' in v4.9.y and has not been reverted there. > > You're right. I thought

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Andi Kleen
> > Cc: sta...@vger.kernel.org # 4.4 and 4.9 > > LGTM for v4.4.y but ... are you sure that this patch applies to v4.9.y ? > Commit edc3b9129cec is 'native' in v4.9.y and has not been reverted there. You're right. I thought it was needed for 4.9 too, but yes it has the CPA pfn patch. So for 4.9

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Andi Kleen
> > Cc: sta...@vger.kernel.org # 4.4 and 4.9 > > LGTM for v4.4.y but ... are you sure that this patch applies to v4.9.y ? > Commit edc3b9129cec is 'native' in v4.9.y and has not been reverted there. You're right. I thought it was needed for 4.9 too, but yes it has the CPA pfn patch. So for 4.9

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Guenter Roeck
On Sat, Aug 25, 2018 at 06:50:15AM -0700, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Guenter Roeck
On Sat, Aug 25, 2018 at 06:50:15AM -0700, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Greg KH
On Sat, Aug 25, 2018 at 06:50:15AM -0700, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Greg KH
On Sat, Aug 25, 2018 at 06:50:15AM -0700, Andi Kleen wrote: > From: Andi Kleen > > Patch for stable only to fix boot resets caused by the L1TF patches. > > Stable trees reverted the following patch > > Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" > > This reverts

[PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Andi Kleen
From: Andi Kleen Patch for stable only to fix boot resets caused by the L1TF patches. Stable trees reverted the following patch Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is commit

[PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-08-25 Thread Andi Kleen
From: Andi Kleen Patch for stable only to fix boot resets caused by the L1TF patches. Stable trees reverted the following patch Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers" This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is commit