Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Thomas Gleixner
On Tue, 14 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 10:14:36PM +0100, Thomas Gleixner wrote: > > I can see where you are heading to. Now the case I was looking at is: > > > > arch_get_unmapped_area_topdown() > > > > addr0 = addr; > > > > > > if (addr) {

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Thomas Gleixner
On Tue, 14 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 10:14:36PM +0100, Thomas Gleixner wrote: > > I can see where you are heading to. Now the case I was looking at is: > > > > arch_get_unmapped_area_topdown() > > > > addr0 = addr; > > > > > > if (addr) {

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 10:17:30PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100,

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 10:17:30PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100,

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 10:14:36PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > > > > > It will succeed with 5-level paging. > > > > > > > > And why is this allowed? > > > > > > > > > It

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-14 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 10:14:36PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > > > > > It will succeed with 5-level paging. > > > > > > > > And why is this allowed? > > > > > > > > > It

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > > > > It will succeed with 5-level paging. > > > > > > And why is this allowed? > > > > > > > It should be safe as with 4-level paging such request would fail and > > > > it's > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > > > > It will succeed with 5-level paging. > > > > > > And why is this allowed? > > > > > > > It should be safe as with 4-level paging such request would fail and > > > > it's > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Thomas Gleixner wrote: > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 08:14:54PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Thomas Gleixner wrote: > > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > In case of 5-level paging, we don't put any

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 05:57:03PM +0100, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > In case of 5-level paging, we don't put any

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > In case of 5-level paging, we don't put any mapping above 47-bit,

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Thomas Gleixner wrote: > On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > > > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > > > In case of 5-level paging, we don't put any mapping above 47-bit,

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > In case of 5-level paging, we don't put any mapping above 47-bit, unless > > > userspace explicitly asked for it. > > > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Kirill A. Shutemov wrote: > On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > > > In case of 5-level paging, we don't put any mapping above 47-bit, unless > > > userspace explicitly asked for it. > > > >

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > In case of 5-level paging, we don't put any mapping above 47-bit, unless > > userspace explicitly asked for it. > > > > Userspace can ask for allocation from full address space

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Kirill A. Shutemov
On Mon, Nov 13, 2017 at 04:43:26PM +0100, Thomas Gleixner wrote: > On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > > > In case of 5-level paging, we don't put any mapping above 47-bit, unless > > userspace explicitly asked for it. > > > > Userspace can ask for allocation from full address space

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > In case of 5-level paging, we don't put any mapping above 47-bit, unless > userspace explicitly asked for it. > > Userspace can ask for allocation from full address space by specifying > hint address above 47-bit. > > Nicholas noticed that current

Re: [PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-13 Thread Thomas Gleixner
On Tue, 7 Nov 2017, Kirill A. Shutemov wrote: > In case of 5-level paging, we don't put any mapping above 47-bit, unless > userspace explicitly asked for it. > > Userspace can ask for allocation from full address space by specifying > hint address above 47-bit. > > Nicholas noticed that current

[PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-07 Thread Kirill A. Shutemov
In case of 5-level paging, we don't put any mapping above 47-bit, unless userspace explicitly asked for it. Userspace can ask for allocation from full address space by specifying hint address above 47-bit. Nicholas noticed that current implementation violates this interface: we can get vma

[PATCH] x86/mm: Do not allow non-MAP_FIXED mapping across DEFAULT_MAP_WINDOW border

2017-11-07 Thread Kirill A. Shutemov
In case of 5-level paging, we don't put any mapping above 47-bit, unless userspace explicitly asked for it. Userspace can ask for allocation from full address space by specifying hint address above 47-bit. Nicholas noticed that current implementation violates this interface: we can get vma