Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Nick Desaulniers
On Mon, Oct 15, 2018 at 9:57 AM Nick Desaulniers wrote: > I broke this myself in commit 815f0ddb346c > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). > Thanks for the suggestion, will verify then send a patch with your > suggested by tag. Thanks everyone for helping us sort

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Nick Desaulniers
On Mon, Oct 15, 2018 at 9:03 AM Andy Lutomirski wrote: > > On Mon, Oct 15, 2018 at 8:31 AM Josh Poimboeuf wrote: > > > > On Mon, Oct 15, 2018 at 08:22:21AM -0700, Nathan Chancellor wrote: > > > > >>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long > > > > >>> error_code, > >

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 09:03:40AM -0700, Andy Lutomirski wrote: > That being said, the generic macro is: > > # define unreachable() do { annotate_reachable(); do { } while (1); } while > (0) > > I'm probably missing some subtlety here, but shouldn't that be > annotate_*un*reachable()? That cod

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Nathan Chancellor
On Mon, Oct 15, 2018 at 09:03:40AM -0700, Andy Lutomirski wrote: > On Mon, Oct 15, 2018 at 8:31 AM Josh Poimboeuf wrote: > > > > On Mon, Oct 15, 2018 at 08:22:21AM -0700, Nathan Chancellor wrote: > > > > >>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long > > > > >>> error_cod

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Andy Lutomirski
On Mon, Oct 15, 2018 at 8:31 AM Josh Poimboeuf wrote: > > On Mon, Oct 15, 2018 at 08:22:21AM -0700, Nathan Chancellor wrote: > > > >>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long > > > >>> error_code, > > > >>> * and then double-fault, though, because we're

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 08:22:21AM -0700, Nathan Chancellor wrote: > > >>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long > > >>> error_code, > > >>> * and then double-fault, though, because we're likely to > > >>> * break the console driver and

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Nathan Chancellor
On Mon, Oct 15, 2018 at 07:34:14AM -0700, Andy Lutomirski wrote: > > > > On Oct 14, 2018, at 10:17 PM, Nathan Chancellor > > wrote: > > > >> On Sun, Oct 14, 2018 at 08:43:18PM -0700, Andy Lutomirski wrote: > >> On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers > >> wrote: > >>> > >>> Fixes th

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Andy Lutomirski
> On Oct 14, 2018, at 10:17 PM, Nathan Chancellor > wrote: > >> On Sun, Oct 14, 2018 at 08:43:18PM -0700, Andy Lutomirski wrote: >> On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers >> wrote: >>> >>> Fixes the objtool warning: >>> arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: un

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-15 Thread Josh Poimboeuf
On Sun, Oct 14, 2018 at 10:17:05PM -0700, Nathan Chancellor wrote: > On Sun, Oct 14, 2018 at 08:43:18PM -0700, Andy Lutomirski wrote: > > On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers > > wrote: > > > > > > Fixes the objtool warning: > > > arch/x86/mm/fault.o: warning: objtool: no_context()+0x2

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-14 Thread Nathan Chancellor
On Sun, Oct 14, 2018 at 08:43:18PM -0700, Andy Lutomirski wrote: > On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers > wrote: > > > > Fixes the objtool warning: > > arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable > > instruction > > > > Link: https://github.com/ClangBuiltLinu

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-14 Thread Andy Lutomirski
On Sun, Oct 14, 2018 at 5:37 PM Nick Desaulniers wrote: > > Fixes the objtool warning: > arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable > instruction > > Link: https://github.com/ClangBuiltLinux/linux/issues/204 > Signed-off-by: Nick Desaulniers > --- > arch/x86/mm/fault.

[PATCH] x86/mm: annotate no_context with UNWIND_HINTS

2018-10-14 Thread Nick Desaulniers
Fixes the objtool warning: arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable instruction Link: https://github.com/ClangBuiltLinux/linux/issues/204 Signed-off-by: Nick Desaulniers --- arch/x86/mm/fault.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git