Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static

2017-12-06 Thread Mike Travis
I know you've already changed it but the UV changes look fine, so ACK for that. Thanks. On 12/6/2017 9:08 AM, Colin King wrote: From: Colin Ian King Functions uv_handle_nmi and uv_nmi_setup_common are local to the source and do not need to be in global scope, so make them static. Cleans up s

Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static

2017-12-06 Thread Ingo Molnar
* Colin King wrote: > From: Colin Ian King > > Functions uv_handle_nmi and uv_nmi_setup_common are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'uv_handle_nmi' was not declared. Should it be static? > symbol 'uv_nmi_

[PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static

2017-12-06 Thread Colin King
From: Colin Ian King Functions uv_handle_nmi and uv_nmi_setup_common are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'uv_handle_nmi' was not declared. Should it be static? symbol 'uv_nmi_setup_common' was not declared. Should