Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller

2017-08-25 Thread Colin Ian King
On 25/08/17 18:53, Andy Shevchenko wrote: > On Fri, 2017-08-25 at 19:51 +0200, Lukas Wunner wrote: >> On Fri, Aug 25, 2017 at 05:32:06PM +0100, Colin King wrote: >>> --- a/arch/x86/platform/intel-mid/pwr.c >>> +++ b/arch/x86/platform/intel-mid/pwr.c >>> @@ -444,7 +444,7 @@ static int mid_set_initia

Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller

2017-08-25 Thread Andy Shevchenko
On Fri, 2017-08-25 at 19:51 +0200, Lukas Wunner wrote: > On Fri, Aug 25, 2017 at 05:32:06PM +0100, Colin King wrote: > > --- a/arch/x86/platform/intel-mid/pwr.c > > +++ b/arch/x86/platform/intel-mid/pwr.c > > @@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr > > *pwr, const u32 *s

Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller

2017-08-25 Thread Lukas Wunner
On Fri, Aug 25, 2017 at 05:32:06PM +0100, Colin King wrote: > --- a/arch/x86/platform/intel-mid/pwr.c > +++ b/arch/x86/platform/intel-mid/pwr.c > @@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr *pwr, > const u32 *states) > static int pnw_set_initial_state(struct mid_pwr *pwr)

Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller

2017-08-25 Thread Andy Shevchenko
On Fri, 2017-08-25 at 17:32 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate arrays on the stack, instead make them static . > Makes the object code smaller by 76 bytes: > > Before: >    text    data bss dec hex > filename >    4217    1540 128    5

[PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller

2017-08-25 Thread Colin King
From: Colin Ian King Don't populate arrays on the stack, instead make them static . Makes the object code smaller by 76 bytes: Before: textdata bss dec hex filename 42171540 128588516fd arch/x86/platform/intel-mid/pwr.o After: textdata bss de