Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Hans de Goede
HI, On 07-10-2019 23:52, Arvind Sankar wrote: On Mon, Oct 07, 2019 at 10:31:49PM +0200, Hans de Goede wrote: HI, On 07-10-2019 22:05, Nathan Chancellor wrote: On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: Since we link purgatory.ro with -r aka we enable "incremental

Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 10:31:49PM +0200, Hans de Goede wrote: > HI, > > On 07-10-2019 22:05, Nathan Chancellor wrote: > > On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: > >> Since we link purgatory.ro with -r aka we enable "incremental linking" > >> no checks for unresolved

Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Hans de Goede
HI, On 07-10-2019 22:05, Nathan Chancellor wrote: On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: Since we link purgatory.ro with -r aka we enable "incremental linking" no checks for unresolved symbols is done while linking purgatory.ro. Changes to the sha256 code has caused

Re: [PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Nathan Chancellor
On Mon, Oct 07, 2019 at 07:55:46PM +0200, Hans de Goede wrote: > Since we link purgatory.ro with -r aka we enable "incremental linking" > no checks for unresolved symbols is done while linking purgatory.ro. > > Changes to the sha256 code has caused the purgatory in 5.4-rc1 to have > a missing

[PATCH] x86/purgatory: Make sure we fail the build if purgatory.ro has missing symbols

2019-10-07 Thread Hans de Goede
Since we link purgatory.ro with -r aka we enable "incremental linking" no checks for unresolved symbols is done while linking purgatory.ro. Changes to the sha256 code has caused the purgatory in 5.4-rc1 to have a missing symbol on memzero_explicit, yet things still happily build. This commit