Re: [PATCH] x86/resctrl: Fix memory leak on kernfs dir removal

2020-10-26 Thread Willem de Bruijn
On Mon, Oct 26, 2020 at 12:24 PM Reinette Chatre wrote: > > +Xiaochen > > Hi Willem, > > As you described in the report you sent directly to us there are indeed > more issues than the one described here surrounding the kernfs node > reference counting in resctrl. Xiaochen is actively working on

Re: [PATCH] x86/resctrl: Fix memory leak on kernfs dir removal

2020-10-26 Thread Reinette Chatre
+Xiaochen Hi Willem, As you described in the report you sent directly to us there are indeed more issues than the one described here surrounding the kernfs node reference counting in resctrl. Xiaochen is actively working on patch(es) for all the issues and you could continue working with him

[PATCH] x86/resctrl: Fix memory leak on kernfs dir removal

2020-10-26 Thread Willem de Bruijn
From: Willem de Bruijn Resctrl takes an extra kernfs ref on directory entries, to access the entry on cleanup in rdtgroup_kn_unlock after removing the entire subtree with kfree_remove. But the path takes an extra ref both on mkdir and on rmdir. The kernfs_get on mkdir causes a memleak in the