Re: [PATCH] x86/sched/dynamic-ticks: Call new schedule_irq_disable() for scheduling in entry_64.S

2013-05-10 Thread Frederic Weisbecker
On Thu, May 09, 2013 at 08:47:09PM -0400, Steven Rostedt wrote: > On Fri, 2013-05-10 at 02:22 +0200, Frederic Weisbecker wrote: > > > > > @@ -654,6 +653,7 @@ sysret_check: > > > LOCKDEP_SYS_EXIT > > > DISABLE_INTERRUPTS(CLBR_NONE) > > > TRACE_IRQS_OFF > > > +sysret_check_irqsoff: > > > mo

Re: [PATCH] x86/sched/dynamic-ticks: Call new schedule_irq_disable() for scheduling in entry_64.S

2013-05-09 Thread Steven Rostedt
On Thu, 2013-05-09 at 20:47 -0400, Steven Rostedt wrote: > > > > > + > > > + local_irq_enable(); > > > + __schedule(); > > > > Are you sure it's fine to call __schedule() instead of schedule()? > > I don't know much about the blk work to handle there but it may be > > worth considering. > > Not

Re: [PATCH] x86/sched/dynamic-ticks: Call new schedule_irq_disable() for scheduling in entry_64.S

2013-05-09 Thread Steven Rostedt
On Fri, 2013-05-10 at 02:22 +0200, Frederic Weisbecker wrote: > > > @@ -654,6 +653,7 @@ sysret_check: > > LOCKDEP_SYS_EXIT > > DISABLE_INTERRUPTS(CLBR_NONE) > > TRACE_IRQS_OFF > > +sysret_check_irqsoff: > > movl TI_flags+THREAD_INFO(%rsp,RIP-ARGOFFSET),%edx > > andl %edi,%edx

Re: [PATCH] x86/sched/dynamic-ticks: Call new schedule_irq_disable() for scheduling in entry_64.S

2013-05-09 Thread Frederic Weisbecker
On Wed, May 08, 2013 at 09:21:20PM -0400, Steven Rostedt wrote: > I started testing the new NOHZ_FULL in the kernel and had some issues, > so I started function tracing and this bug report came out: > > > [23446.458073] [ cut here ] > [23446.461028] WARNING: > at /home/ros

[PATCH] x86/sched/dynamic-ticks: Call new schedule_irq_disable() for scheduling in entry_64.S

2013-05-08 Thread Steven Rostedt
I started testing the new NOHZ_FULL in the kernel and had some issues, so I started function tracing and this bug report came out: [23446.458073] [ cut here ] [23446.461028] WARNING: at /home/rostedt/work/git/linux-trace.git/kernel/rcutree.c:388 rcu_eqs_enter+0x4b/0x89() [