Re: [PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-07 Thread Jarkko Sakkinen
On Fri, Feb 05, 2021 at 08:43:24AM +0100, Daniel Vetter wrote: > On Fri, Feb 5, 2021 at 3:26 AM Jarkko Sakkinen wrote: > > > > On Thu, Feb 04, 2021 at 07:45:19PM +0100, Daniel Vetter wrote: > > > References: > > > https://lore.kernel.org/dri-devel/20201127164131.2244124-1-daniel.vet...@ffwll.ch/

Re: [PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-04 Thread Daniel Vetter
On Fri, Feb 5, 2021 at 3:26 AM Jarkko Sakkinen wrote: > > On Thu, Feb 04, 2021 at 07:45:19PM +0100, Daniel Vetter wrote: > > References: > > https://lore.kernel.org/dri-devel/20201127164131.2244124-1-daniel.vet...@ffwll.ch/ > > What is the difference between this and "Link:" anyway? Afaik Refere

Re: [PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-04 Thread Jarkko Sakkinen
On Thu, Feb 04, 2021 at 07:45:19PM +0100, Daniel Vetter wrote: > PTE insertion is fundamentally racy, and this check doesn't do > anything useful. Quoting Sean: > > "Yeah, it can be whacked. The original, never-upstreamed code asserted that > the > resolved PFN matched the PFN being installed by

Re: [PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-04 Thread Jarkko Sakkinen
On Thu, Feb 04, 2021 at 07:45:19PM +0100, Daniel Vetter wrote: > References: > https://lore.kernel.org/dri-devel/20201127164131.2244124-1-daniel.vet...@ffwll.ch/ What is the difference between this and "Link:" anyway? /Jarkko

[PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-04 Thread Daniel Vetter
PTE insertion is fundamentally racy, and this check doesn't do anything useful. Quoting Sean: "Yeah, it can be whacked. The original, never-upstreamed code asserted that the resolved PFN matched the PFN being installed by the fault handler as a sanity check on the SGX driver's EPC management. Th