Re: [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t

2020-11-29 Thread Walt Drummond
Got it. Thanks again Al. On Sat, Nov 28, 2020 at 7:28 PM Al Viro wrote: > > On Sat, Nov 28, 2020 at 06:19:31PM -0800, Walt Drummond wrote: > > Thanks Al. I want to understand the nuance, so please bear with me as I > > reason this out. The cast in stone nature of this is due to both the need

Re: [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t

2020-11-28 Thread Al Viro
On Sat, Nov 28, 2020 at 06:19:31PM -0800, Walt Drummond wrote: > Thanks Al. I want to understand the nuance, so please bear with me as I > reason this out. The cast in stone nature of this is due to both the need > to keep userspace and kernel space in sync (ie, you'd have to coordinate > libc

Re: [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t

2020-11-28 Thread Walt Drummond
(Sorry, resending as Gmail decided to ignore "Plaintext mode") Thanks Al. I want to understand the nuance, so please bear with me as I reason this out. The cast in stone nature of this is due to both the need to keep userspace and kernel space in sync (ie, you'd have to coordinate libc and

Re: [PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t

2020-11-28 Thread Al Viro
On Thu, Nov 19, 2020 at 02:11:33PM -0800, Walt Drummond wrote: > The macro unsafe_put_sigmask() only handles the first 64 bits of the > sigmask_t, which works today. However, if the definition of the > sigset_t structure ever changed, ... existing userland would get fucked over, since sigset_t

[PATCH] x86/signals: Fix save/restore signal stack to correctly support sigset_t

2020-11-19 Thread Walt Drummond
The macro unsafe_put_sigmask() only handles the first 64 bits of the sigmask_t, which works today. However, if the definition of the sigset_t structure ever changed, this would fail to setup/restore the signal stack properly and likely corrupt the sigset. This patch updates unsafe_put_sigmask()