Re: [PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only

2017-04-10 Thread Thomas Gleixner
On Mon, 10 Apr 2017, Thomas Gleixner wrote: > On Wed, 5 Apr 2017, Mathias Krause wrote: > > @@ -62,13 +64,18 @@ int __init sysenter_setup(void) > > /* Register vsyscall32 into the ABI table */ > > #include > > > > +static const int zero; > > +static const int one = 1; > > + > > static struct

Re: [PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only

2017-04-10 Thread Thomas Gleixner
On Wed, 5 Apr 2017, Mathias Krause wrote: > @@ -62,13 +64,18 @@ int __init sysenter_setup(void) > /* Register vsyscall32 into the ABI table */ > #include > > +static const int zero; > +static const int one = 1; > + > static struct ctl_table abi_table2[] = { > { > .procname

Re: [PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only

2017-04-06 Thread Andy Lutomirski
On Wed, Apr 5, 2017 at 1:36 PM, Mathias Krause wrote: > If either via kernel command line 'vdso32=' or via 'sysctl abi.vsyscall32' > vdso32_enabled gets set to a value below 0 or above 1, load_vdso32() won't > map the vDSO but ARCH_DLINFO_IA32 would still pass an AT_SYSINFO_EHDR > auxiliary vector

[PATCH] x86/vdso: ensure vdso32_enabled gets set to valid values only

2017-04-05 Thread Mathias Krause
If either via kernel command line 'vdso32=' or via 'sysctl abi.vsyscall32' vdso32_enabled gets set to a value below 0 or above 1, load_vdso32() won't map the vDSO but ARCH_DLINFO_IA32 would still pass an AT_SYSINFO_EHDR auxiliary vector, however with a NULL pointer. That'll make any program trying