Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-03 Thread Nikolay Borisov
On 04/01/2016 06:49 PM, Andy Lutomirski wrote: > Sadly, hardware turbo mode buttons are few and far between in these > degenerate times. Add a software control at /proc/sys/turbo_mode. > > Unfortunately, Linux graphical environments have become very > heavy-weight and are essentially unusable o

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-03 Thread Borislav Petkov
On Sun, Apr 03, 2016 at 11:55:34AM +0200, Thomas Gleixner wrote: > While at it can you please make a turbo = 0 call when we hit a WARN/BUG/Panic > so the messages spill slower over the screen? Good idea! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-03 Thread Thomas Gleixner
On Sat, 2 Apr 2016, Andy Lutomirski wrote: > On Fri, Apr 1, 2016 at 9:10 AM, Thomas Gleixner wrote: > >> + if (turbo_mode) > >> + write_cr0(cr0 & ~X86_CR0_CD); > >> + else > >> + write_cr0(cr0 | X86_CR0_CD); > > > > I think proper turbo mode disable requires ~(X86_C

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-02 Thread Andy Lutomirski
On Fri, Apr 1, 2016 at 9:10 AM, Thomas Gleixner wrote: > On Fri, 1 Apr 2016, Andy Lutomirski wrote: >> +static void update_local_turbo_mode(void *dummy) >> +{ >> + unsigned long cr0 = read_cr0(); >> + >> + /* >> + * KVM doesn't properly handle CD. >> + * >> + * XXX: this may

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-01 Thread Thomas Gleixner
On Fri, 1 Apr 2016, Andy Lutomirski wrote: > +static void update_local_turbo_mode(void *dummy) > +{ > + unsigned long cr0 = read_cr0(); > + > + /* > + * KVM doesn't properly handle CD. > + * > + * XXX: this may interact poorly with CPU hotplug. Please cc these crazy folks wh

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-01 Thread kbuild test robot
Hi Andy, [auto build test WARNING on tip/x86/core] [also build test WARNING on v4.6-rc1 next-20160401] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Andy-Lutomirski/x86-Add-a-turbo-mode-sysct

Re: [PATCH] x86: Add a turbo mode sysctl

2016-04-01 Thread Borislav Petkov
On Fri, Apr 01, 2016 at 08:49:53AM -0700, Andy Lutomirski wrote: > Sadly, hardware turbo mode buttons are few and far between in these > degenerate times. Add a software control at /proc/sys/turbo_mode. > > Unfortunately, Linux graphical environments have become very > heavy-weight and are essent

[PATCH] x86: Add a turbo mode sysctl

2016-04-01 Thread Andy Lutomirski
Sadly, hardware turbo mode buttons are few and far between in these degenerate times. Add a software control at /proc/sys/turbo_mode. Unfortunately, Linux graphical environments have become very heavy-weight and are essentially unusable on non-Turbo systems. The VT console works very well, thoug