Re: [PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-19 Thread Siarhei Liakh
On Tue, 19 Jun 2018, Andy Lutomirski wrote:  > On Jun 19, 2018, at 9:15 AM, Siarhei Liakh > wrote: > > > On Mon, 18 Jun 2018, Andy Lutomirski wrote: > > > > > > On Thu, Jun 14, 2018 at 10:10 PM Siarhei Liakh > > > > wrote: > > > > > > > > > > fpu__drop() has an explicit fwait which under so

Re: [PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-19 Thread Andy Lutomirski
> On Jun 18, 2018, at 11:23 PM, Thomas Gleixner wrote: > >> On Mon, 18 Jun 2018, Andy Lutomirski wrote: >> >> On Thu, Jun 14, 2018 at 10:10 PM Siarhei Liakh >> wrote: >>> >>> fpu__drop() has an explicit fwait which under some conditions can trigger >>> a fixable FPU exception while in kerne

Re: [PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-18 Thread Thomas Gleixner
On Mon, 18 Jun 2018, Andy Lutomirski wrote: > On Thu, Jun 14, 2018 at 10:10 PM Siarhei Liakh > wrote: > > > > fpu__drop() has an explicit fwait which under some conditions can trigger > > a fixable FPU exception while in kernel. Thus, we should attempt to fixup > > the exception first, and only c

Re: [PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-18 Thread Andy Lutomirski
On Thu, Jun 14, 2018 at 10:10 PM Siarhei Liakh wrote: > > fpu__drop() has an explicit fwait which under some conditions can trigger > a fixable FPU exception while in kernel. Thus, we should attempt to fixup > the exception first, and only call notify_die() if the fixup failed just > like in do_ge

[PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-14 Thread Siarhei Liakh
fpu__drop() has an explicit fwait which under some conditions can trigger a fixable FPU exception while in kernel. Thus, we should attempt to fixup the exception first, and only call notify_die() if the fixup failed just like in do_general_protection(). The original call sequence incorrectly trigge