Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
On 2015/08/03 20:03, Borislav Petkov wrote: > On Mon, Aug 03, 2015 at 11:08:07AM +0200, Peter Zijlstra wrote: >> For those of us suffering OCDs and all, its a good change though. The >> alfabet song does go: A, B, C, D etc.. after all. Not: A, C, D, B ... > > ... except that x86 encoding orders

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
On 2015/08/03 18:44, Alexander Shishkin wrote: > On 3 August 2015 at 12:08, Peter Zijlstra wrote: >> On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: >>> Takao Indoh writes: >> >>> Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a >>> property of a separate

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Borislav Petkov
On Mon, Aug 03, 2015 at 11:08:07AM +0200, Peter Zijlstra wrote: > For those of us suffering OCDs and all, its a good change though. The > alfabet song does go: A, B, C, D etc.. after all. Not: A, C, D, B ... ... except that x86 encoding orders regs like it was originally: AX, CX, DX, BX, ...

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Alexander Shishkin
On 3 August 2015 at 12:08, Peter Zijlstra wrote: > On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: >> Takao Indoh writes: > >> Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a >> property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but >> 12

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Peter Zijlstra
On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: > Takao Indoh writes: > Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a > property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but > 12 is not always PAGE_SHIFT. PAGE_SHIFT is _always_ 12 on

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Alexander Shishkin
Takao Indoh writes: > This patch just cleans up some files of Intel Processor Trace, does not > change its behavior. Removing unused definition, replace a constant > value with macro, etc. > > Signed-off-by: Takao Indoh > --- > arch/x86/kernel/cpu/intel_pt.h| 33

[PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
This patch just cleans up some files of Intel Processor Trace, does not change its behavior. Removing unused definition, replace a constant value with macro, etc. Signed-off-by: Takao Indoh --- arch/x86/kernel/cpu/intel_pt.h| 33 +---

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
On 2015/08/03 20:03, Borislav Petkov wrote: On Mon, Aug 03, 2015 at 11:08:07AM +0200, Peter Zijlstra wrote: For those of us suffering OCDs and all, its a good change though. The alfabet song does go: A, B, C, D etc.. after all. Not: A, C, D, B ... ... except that x86 encoding orders regs

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
On 2015/08/03 18:44, Alexander Shishkin wrote: On 3 August 2015 at 12:08, Peter Zijlstra pet...@infradead.org wrote: On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT,

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Alexander Shishkin
On 3 August 2015 at 12:08, Peter Zijlstra pet...@infradead.org wrote: On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a property of a separate hardware block,

[PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Takao Indoh
This patch just cleans up some files of Intel Processor Trace, does not change its behavior. Removing unused definition, replace a constant value with macro, etc. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com --- arch/x86/kernel/cpu/intel_pt.h| 33

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Borislav Petkov
On Mon, Aug 03, 2015 at 11:08:07AM +0200, Peter Zijlstra wrote: For those of us suffering OCDs and all, its a good change though. The alfabet song does go: A, B, C, D etc.. after all. Not: A, C, D, B ... ... except that x86 encoding orders regs like it was originally: AX, CX, DX, BX, ... Don't

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Peter Zijlstra
On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: Takao Indoh indou.ta...@jp.fujitsu.com writes: Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but 12 is not always PAGE_SHIFT.

Re: [PATCH] x86: Clean up files of Intel Processor Trace

2015-08-03 Thread Alexander Shishkin
Takao Indoh indou.ta...@jp.fujitsu.com writes: This patch just cleans up some files of Intel Processor Trace, does not change its behavior. Removing unused definition, replace a constant value with macro, etc. Signed-off-by: Takao Indoh indou.ta...@jp.fujitsu.com ---