Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-10 Thread Borislav Petkov
On Mon, Nov 10, 2014 at 05:03:16PM +0800, Daniel J Blueman wrote: > Yes, totalram_pages doesn't count the MMIO hole, whereas max_pfn does. > > I've made NumaConnect firmware changes that will guarantee max_pfn is always > aligned to at least 2GB, so bdee237c0343a5d1a6cf72c7ea68e88338b26e08 "x86: >

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-10 Thread Daniel J Blueman
On 11/06/2014 07:56 PM, Borislav Petkov wrote: On Thu, Nov 06, 2014 at 07:10:45PM +0800, Daniel J Blueman wrote: "As the first check for 64GB or larger memory returns a 2GB memory block size in that case, the following check for less than 64GB will always Right, but why isn't there a simple el

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-06 Thread Borislav Petkov
On Thu, Nov 06, 2014 at 07:10:45PM +0800, Daniel J Blueman wrote: > "As the first check for 64GB or larger memory returns a 2GB memory > block size in that case, the following check for less than 64GB will > always Right, but why isn't there a simple else? Instead, the >64GB case is looking at tot

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-06 Thread Daniel J Blueman
On 11/06/2014 06:40 PM, Borislav Petkov wrote: On Thu, Nov 06, 2014 at 06:33:40PM +0800, Daniel J Blueman wrote: As the first check for 64GB or larger memory returns a 2GB memory block size in that case, the following check for less than 64GB will always evaluate true, leading to unreachable cod

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-06 Thread Borislav Petkov
On Thu, Nov 06, 2014 at 06:33:40PM +0800, Daniel J Blueman wrote: > As the first check for 64GB or larger memory returns a 2GB memory block size > in that case, the following check for less than 64GB will always evaluate > true, leading to unreachable code. I'm reading this as this code is never r

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-06 Thread Daniel J Blueman
On 11/06/2014 05:40 PM, Borislav Petkov wrote: On Thu, Nov 06, 2014 at 12:50:14PM +0800, Daniel J Blueman wrote: Drop the unused code from selecting a fixed memory block size of 2GB on large-memory x86-64 systems. Signed-off-by: Daniel J Blueman This commit message is seriously lacking an ex

Re: [PATCH] x86: Drop redundant memory-block sizing code

2014-11-06 Thread Borislav Petkov
On Thu, Nov 06, 2014 at 12:50:14PM +0800, Daniel J Blueman wrote: > Drop the unused code from selecting a fixed memory block size of 2GB > on large-memory x86-64 systems. > > Signed-off-by: Daniel J Blueman This commit message is seriously lacking an explanation why? Why is it unused, why is it

[PATCH] x86: Drop redundant memory-block sizing code

2014-11-05 Thread Daniel J Blueman
Drop the unused code from selecting a fixed memory block size of 2GB on large-memory x86-64 systems. Signed-off-by: Daniel J Blueman --- arch/x86/mm/init_64.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c inde