RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-25 Thread Shivappa, Vikas
thanks to my email client , last email was sent by mistake !! sorry for spam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-25 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Wed, 19 Nov 2014, Vikas Shivappa wrote: > +/* maximum possible cbm length */ > +#define MAX_CBM_LENGTH 32 > + > +#define IA32_CBMMAX_MASK(x)(0x & (~((u64)(1 << x)

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-25 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Wed, 19 Nov 2014, Vikas Shivappa wrote: +/* maximum possible cbm length */ +#define MAX_CBM_LENGTH 32 + +#define IA32_CBMMAX_MASK(x)(0x (~((u64)(1 x) - 1))) Unused define

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-25 Thread Shivappa, Vikas
thanks to my email client , last email was sent by mistake !! sorry for spam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-24 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Wed, 19 Nov 2014, Vikas Shivappa wrote: > +/* maximum possible cbm length */ > +#define MAX_CBM_LENGTH 32 > + > +#define IA32_CBMMAX_MASK(x)(0x & (~((u64)(1 << x)

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-24 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Fri, 21 Nov 2014, Vikas Shivappa wrote: > On Fri, 21 Nov 2014, Thomas Gleixner wrote: > > On Wed, 19 Nov 2014, Vikas Shivappa wrote: > > > + rdmsr(IA32_PQR_ASSOC, l, h); > > > > Why on e

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-24 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Fri, 21 Nov 2014, Vikas Shivappa wrote: On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Wed, 19 Nov 2014, Vikas Shivappa wrote: + rdmsr(IA32_PQR_ASSOC, l, h); Why on earth do we want to read an MSR on every context

RE: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-24 Thread Shivappa, Vikas
...@infradead.org Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support On Wed, 19 Nov 2014, Vikas Shivappa wrote: +/* maximum possible cbm length */ +#define MAX_CBM_LENGTH 32 + +#define IA32_CBMMAX_MASK(x)(0x (~((u64)(1 x) - 1))) Unused define

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Vikas Shivappa wrote: > On Fri, 21 Nov 2014, Thomas Gleixner wrote: > > On Wed, 19 Nov 2014, Vikas Shivappa wrote: > > > + rdmsr(IA32_PQR_ASSOC, l, h); > > > > Why on earth do we want to read an MSR on every context switch? What's > > wrong with having > > > >

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Matt Fleming wrote: > Something like this? > > first_bit = find_next_bit(map, nr_bits, -1); > zero_bit = find_next_zero_bit(map, nr_bits, first_bit); > > if (find_next_bit(map, nr_bits, zero_bit) < nr_bits) > return -EINVAL; /* non-contiguous

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Matt Fleming
On Fri, 21 Nov, at 03:19:52PM, Thomas Gleixner wrote: > > + barrier(); > > + cqe_genable = true; > > What's the exact point of that barrier? Yes, this definitely needs documenting. Vikas? > > + > > +/* > > + * Tests if only contiguous bits are set. > > + */ > > + > >

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Matt Fleming
On Fri, 21 Nov, at 03:19:52PM, Thomas Gleixner wrote: + barrier(); + cqe_genable = true; What's the exact point of that barrier? Yes, this definitely needs documenting. Vikas? + +/* + * Tests if only contiguous bits are set. + */ + +static inline bool

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Matt Fleming wrote: Something like this? first_bit = find_next_bit(map, nr_bits, -1); zero_bit = find_next_zero_bit(map, nr_bits, first_bit); if (find_next_bit(map, nr_bits, zero_bit) nr_bits) return -EINVAL; /* non-contiguous bits */

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Vikas Shivappa wrote: On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Wed, 19 Nov 2014, Vikas Shivappa wrote: + rdmsr(IA32_PQR_ASSOC, l, h); Why on earth do we want to read an MSR on every context switch? What's wrong with having DEFINE_PER_CPU(u64,

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Fri, 21 Nov 2014, Dave Hansen wrote: On 11/19/2014 05:05 PM, Vikas Shivappa wrote: + /* +* Hard code the checks and values for HSW SKUs. +* Unfortunately! have to check against only these brand name strings. +*/ +

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
Correcting email address for Matt. On Wed, 19 Nov 2014, Vikas Shivappa wrote: What is Cache Allocation Technology ( CAT ) --- Cache Allocation Technology provides a way for the Software (OS/VMM) to restrict cache allocation to a defined 'subset' of

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Borislav Petkov wrote: On Fri, Nov 21, 2014 at 12:00:27PM -0800, Vikas Shivappa wrote: +char hsw_brandstrs[5][64] = { + "Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz", + "Intel(R) Xeon(R) CPU E5-2648L v3 @ 1.80GHz", +

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Dave Hansen wrote: > On 11/19/2014 05:05 PM, Vikas Shivappa wrote: > > + /* > > +* Hard code the checks and values for HSW SKUs. > > +* Unfortunately! have to check against only these brand name strings. > > +*/ > > + > > + for (i = 0; i < 5; i++) > > +

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Dave Hansen
On 11/19/2014 05:05 PM, Vikas Shivappa wrote: > + /* > + * Hard code the checks and values for HSW SKUs. > + * Unfortunately! have to check against only these brand name strings. > + */ > + > + for (i = 0; i < 5; i++) > + if (!strcmp(hsw_brandstrs[i],

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 12:00:27PM -0800, Vikas Shivappa wrote: > >>+char hsw_brandstrs[5][64] = { > >>+ "Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz", > >>+ "Intel(R) Xeon(R) CPU E5-2648L v3 @ 1.80GHz", > >>+ "Intel(R) Xeon(R) CPU

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Wed, 19 Nov 2014, Vikas Shivappa wrote: +/* maximum possible cbm length */ +#define MAX_CBM_LENGTH 32 + +#define IA32_CBMMAX_MASK(x)(0x & (~((u64)(1 << x) - 1))) Unused define. Will remove , is there any

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Thomas Gleixner
On Wed, 19 Nov 2014, Vikas Shivappa wrote: > +/* maximum possible cbm length */ > +#define MAX_CBM_LENGTH 32 > + > +#define IA32_CBMMAX_MASK(x)(0x & (~((u64)(1 << x) - 1))) Unused define. > + > +#define IA32_CBM_MASK 0x

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Thomas Gleixner
On Wed, 19 Nov 2014, Vikas Shivappa wrote: +/* maximum possible cbm length */ +#define MAX_CBM_LENGTH 32 + +#define IA32_CBMMAX_MASK(x)(0x (~((u64)(1 x) - 1))) Unused define. + +#define IA32_CBM_MASK 0x (~0U) ? @@

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Wed, 19 Nov 2014, Vikas Shivappa wrote: +/* maximum possible cbm length */ +#define MAX_CBM_LENGTH 32 + +#define IA32_CBMMAX_MASK(x)(0x (~((u64)(1 x) - 1))) Unused define. Will remove , is there any

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 12:00:27PM -0800, Vikas Shivappa wrote: +char hsw_brandstrs[5][64] = { + Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz, + Intel(R) Xeon(R) CPU E5-2648L v3 @ 1.80GHz, + Intel(R) Xeon(R) CPU E5-2628L v3 @ 2.00GHz,

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Dave Hansen
On 11/19/2014 05:05 PM, Vikas Shivappa wrote: + /* + * Hard code the checks and values for HSW SKUs. + * Unfortunately! have to check against only these brand name strings. + */ + + for (i = 0; i 5; i++) + if (!strcmp(hsw_brandstrs[i], c-x86_model_id)) {

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Dave Hansen wrote: On 11/19/2014 05:05 PM, Vikas Shivappa wrote: + /* +* Hard code the checks and values for HSW SKUs. +* Unfortunately! have to check against only these brand name strings. +*/ + + for (i = 0; i 5; i++) + if

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Borislav Petkov wrote: On Fri, Nov 21, 2014 at 12:00:27PM -0800, Vikas Shivappa wrote: +char hsw_brandstrs[5][64] = { + Intel(R) Xeon(R) CPU E5-2658 v3 @ 2.20GHz, + Intel(R) Xeon(R) CPU E5-2648L v3 @ 1.80GHz, +

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
Correcting email address for Matt. On Wed, 19 Nov 2014, Vikas Shivappa wrote: What is Cache Allocation Technology ( CAT ) --- Cache Allocation Technology provides a way for the Software (OS/VMM) to restrict cache allocation to a defined 'subset' of

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-21 Thread Vikas Shivappa
On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Fri, 21 Nov 2014, Dave Hansen wrote: On 11/19/2014 05:05 PM, Vikas Shivappa wrote: + /* +* Hard code the checks and values for HSW SKUs. +* Unfortunately! have to check against only these brand name strings. +*/ +

[PATCH] x86: Intel Cache Allocation Technology support

2014-11-19 Thread Vikas Shivappa
What is Cache Allocation Technology ( CAT ) --- Cache Allocation Technology provides a way for the Software (OS/VMM) to restrict cache allocation to a defined 'subset' of cache which may be overlapping with other 'subsets'. This feature is used when

[PATCH] x86: Intel Cache Allocation Technology support

2014-11-19 Thread Vikas Shivappa
What is Cache Allocation Technology ( CAT ) --- Cache Allocation Technology provides a way for the Software (OS/VMM) to restrict cache allocation to a defined 'subset' of cache which may be overlapping with other 'subsets'. This feature is used when