Re: [PATCH] x86: Reduce duplicated code in the x86_64 context switch path.

2013-05-13 Thread Ingo Molnar
* Guenter Roeck wrote: > On Sun, May 12, 2013 at 10:14:51PM -0700, Joe Damato wrote: > > Signed-off-by: Joe Damato > > --- > > arch/x86/include/asm/switch_to.h | 30 ++ > > arch/x86/kernel/process_64.c | 29 ++--- > > 2 files changed,

Re: [PATCH] x86: Reduce duplicated code in the x86_64 context switch path.

2013-05-13 Thread Guenter Roeck
On Sun, May 12, 2013 at 10:14:51PM -0700, Joe Damato wrote: > Signed-off-by: Joe Damato > --- > arch/x86/include/asm/switch_to.h | 30 ++ > arch/x86/kernel/process_64.c | 29 ++--- > 2 files changed, 32 insertions(+), 27 deletions(-) >

Re: [PATCH] x86: Reduce duplicated code in the x86_64 context switch path.

2013-05-13 Thread Joe Damato
On Sun, May 12, 2013 at 11:03 PM, H. Peter Anvin wrote: > This is a net addition in code, and send to only make it harder to understand > what is happening. As such I don't think this is a good idea. OK, I tweaked it slightly to break even on lines of code sent a v2. I do think it would be nice

Re: [PATCH] x86: Reduce duplicated code in the x86_64 context switch path.

2013-05-12 Thread H. Peter Anvin
This is a net addition in code, and send to only make it harder to understand what is happening. As such I don't think this is a good idea. Joe Damato wrote: >Signed-off-by: Joe Damato >--- > arch/x86/include/asm/switch_to.h | 30 ++ > arch/x86/kernel/process_64.c

[PATCH] x86: Reduce duplicated code in the x86_64 context switch path.

2013-05-12 Thread Joe Damato
Signed-off-by: Joe Damato --- arch/x86/include/asm/switch_to.h | 30 ++ arch/x86/kernel/process_64.c | 29 ++--- 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/arch/x86/include/asm/switch_to.h b/arch/x86/include/asm/swi