Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-13 Thread H. Peter Anvin
Phillip Susi wrote: H. Peter Anvin wrote: Not just default, it's the only thing supported. -hpa What about va args? IIRC, fastcall fell back to stdcall after using up registers, so va args HAD to be cdecl. On i386 gcc disables regparm implicitly for varadic functions. -hpa

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-13 Thread Phillip Susi
H. Peter Anvin wrote: Not just default, it's the only thing supported. -hpa What about va args? IIRC, fastcall fell back to stdcall after using up registers, so va args HAD to be cdecl. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-13 Thread H. Peter Anvin
Phillip Susi wrote: Harvey Harrison wrote: It was a leftover from before regparm(3) became the default on x86-32. It doesn't have any use now. Harvey You mean the default calling convention is now fastcall instead of cdecl or stdcall? Not just default, it's the only thing supported.

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-13 Thread Phillip Susi
Harvey Harrison wrote: It was a leftover from before regparm(3) became the default on x86-32. It doesn't have any use now. Harvey You mean the default calling convention is now fastcall instead of cdecl or stdcall? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-13 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > fastcall is always defined to be empty, remove it from arch/x86 thanks, i've applied this and your other fastcall patches to x86.git. (except for the non-x86 bits - those will go upstream via the other trees.) Ingo -- To unsubscribe from

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-12 Thread H. Peter Anvin
Harvey Harrison wrote: On Wed, 2007-12-12 at 16:27 -0500, Phillip Susi wrote: Harvey Harrison wrote: fastcall is always defined to be empty, remove it from arch/x86 Why is it always defined to be empty? Why isn't it used anymore? It was a leftover from before regparm(3) became the default

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-12 Thread Harvey Harrison
On Wed, 2007-12-12 at 16:27 -0500, Phillip Susi wrote: > Harvey Harrison wrote: > > fastcall is always defined to be empty, remove it from arch/x86 > > Why is it always defined to be empty? Why isn't it used anymore? > It was a leftover from before regparm(3) became the default on x86-32. It d

Re: [PATCH] x86: Remove all definitions with fastcall

2007-12-12 Thread Phillip Susi
Harvey Harrison wrote: fastcall is always defined to be empty, remove it from arch/x86 Why is it always defined to be empty? Why isn't it used anymore? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH] x86: Remove all definitions with fastcall

2007-12-12 Thread Harvey Harrison
fastcall is always defined to be empty, remove it from arch/x86 Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kernel/apic_32.c|2 +- arch/x86/kernel/cpu/mcheck/k7.c |2 +- arch/x86/kernel/cpu/mcheck/mce.h |2 +- arch/x86/kernel/cpu/mcheck/mce_32.