Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > Ingo, > > Brown paper bag for me. > > in mmap.c in mmap_is_ia32() > > #ifdef X86_32 > > should of course be: > > #ifdef CONFIG_X86_32 > > This would definitely explain the segfaults. Do you want a > replacement patch or incremental? no need,

Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Harvey Harrison
On Tue, 2007-12-11 at 15:08 +0100, Ingo Molnar wrote: > * Jiri Kosina <[EMAIL PROTECTED]> wrote: > > > > hm, it fails to boot on Fedora 8: > > > Freeing unused kernel memory: 296k freed > > > Write protecting the kernel read-only data: 1500k > > > mount[623]: segfault at 000b ip 4d681ab6 sp

Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Harvey Harrison
On Tue, 2007-12-11 at 15:08 +0100, Ingo Molnar wrote: > * Jiri Kosina <[EMAIL PROTECTED]> wrote: > > > > hm, it fails to boot on Fedora 8: > > > Freeing unused kernel memory: 296k freed > > > Write protecting the kernel read-only data: 1500k > > > mount[623]: segfault at 000b ip 4d681ab6 sp

Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Ingo Molnar
* Jiri Kosina <[EMAIL PROTECTED]> wrote: > > hm, it fails to boot on Fedora 8: > > Freeing unused kernel memory: 296k freed > > Write protecting the kernel read-only data: 1500k > > mount[623]: segfault at 000b ip 4d681ab6 sp bf9a1b94 error 6 > > modprobe[625]: segfault at 000b ip 4d6

Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Jiri Kosina
On Tue, 11 Dec 2007, Ingo Molnar wrote: > > > mmap_is_ia32 always true for X86_32, or while emulating IA32 on X86_64 > > > Randomization not supported on X86_32 in legacy layout. Both layouts > > > allow randomization on X86_64. > > thanks for sorting this out - this looks really clean now. I've

Re: [PATCH] x86: Unify mmap_{32|64}.c

2007-12-11 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > mmap_is_ia32 always true for X86_32, or while emulating IA32 on X86_64 > > Randomization not supported on X86_32 in legacy layout. Both layouts > allow randomization on X86_64. thanks for sorting this out - this looks really clean now. I've added

[PATCH] x86: Unify mmap_{32|64}.c

2007-12-10 Thread Harvey Harrison
mmap_is_ia32 always true for X86_32, or while emulating IA32 on X86_64 Randomization not supported on X86_32 in legacy layout. Both layouts allow randomization on X86_64. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Applies against the mm branch of the x86 tree which has Jiri's PIE rew