Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-21 Thread Greg Kroah-Hartman
On Sun, Jan 21, 2018 at 10:50:20AM +0100, Ingo Molnar wrote: > > * Greg Kroah-Hartman wrote: > > > On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote: > > > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C wrote: > > > > > > > > Added stable to CC since the patch series this patch fixes >

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-21 Thread Ingo Molnar
* Greg Kroah-Hartman wrote: > On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote: > > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C wrote: > > > > > > Added stable to CC since the patch series this patch fixes > > > is in stable-queue. > > > > Oh, it wasn't clear from the commit messa

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-21 Thread Greg Kroah-Hartman
On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote: > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C wrote: > > > > Added stable to CC since the patch series this patch fixes > > is in stable-queue. > > Oh, it wasn't clear from the commit message. But I guess the "Fixes:" > tag would have

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-21 Thread Ingo Molnar
* Linus Torvalds wrote: > On Sat, Jan 20, 2018 at 5:14 PM, Laura Abbott wrote: > > > > I hadn't seen this picked up yet so sending explicitly > > Ingo, I just took this directly as a patch. Thanks! Ingo

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-20 Thread Linus Torvalds
On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C wrote: > > Added stable to CC since the patch series this patch fixes > is in stable-queue. Oh, it wasn't clear from the commit message. But I guess the "Fixes:" tag would have caught Greg's eye regardless. Anyway, Laura's fix is commit 91cfc88c66bf ("x

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-20 Thread Gabriel C
On 21.01.2018 02:23, Linus Torvalds wrote: On Sat, Jan 20, 2018 at 5:14 PM, Laura Abbott wrote: I hadn't seen this picked up yet so sending explicitly Ingo, I just took this directly as a patch. Added stable to CC since the patch series this patch fixes is in stable-queue. Regards, Gabri

Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-20 Thread Linus Torvalds
On Sat, Jan 20, 2018 at 5:14 PM, Laura Abbott wrote: > > I hadn't seen this picked up yet so sending explicitly Ingo, I just took this directly as a patch. Linus

[PATCH] x86: Use __nostackprotect for sme_encrypt_kernel

2018-01-20 Thread Laura Abbott
Commit bacf6b499e11 ("x86/mm: Use a struct to reduce parameters for SME PGD mapping") moved some parameters into a structure. The structure was large enough to trigger the stack protection canary in sme_encrypt_kernel which doesn't work this early, causing reboots. Mark sme_encrypt_kernel appropria