Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 12/09/2015 10:27 AM, Jan Beulich wrote: On 09.12.15 at 16:15, wrote: On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

>>> On 09.12.15 at 16:15, wrote: > On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: >> On 2015-12-09 15:42, Jan Beulich wrote: >> On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void)

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

Sander Eikelenboom writes: > On 2015-12-09 15:42, Jan Beulich wrote: > On 09.12.15 at 15:32, wrote: >>> --- a/arch/x86/kernel/rtc.c >>> +++ b/arch/x86/kernel/rtc.c >>> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) >>> } >>> #endif >>> >>> + if (paravirt_enabled()) >>> +

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) } #endif +if (paravirt_enabled()) +return

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) } #endif + if (paravirt_enabled()) + return -ENODEV; What about Xen Dom0? Jan

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

>>> On 09.12.15 at 15:32, wrote: > --- a/arch/x86/kernel/rtc.c > +++ b/arch/x86/kernel/rtc.c > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) > } > #endif > > + if (paravirt_enabled()) > + return -ENODEV; What about Xen Dom0? Jan -- To unsubscribe from this

[PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

Adding the rtc platform device in a Xen PV guests causes an IRQ conflict because these guests do not have a legacy PIC. In a single VCPU Xen PV guest we should have: /proc/interrupts: CPU0 0: 4934 xen-percpu-virq timer0 1: 0 xen-percpu-ipi spinlock0

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) } #endif +if

[PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

Adding the rtc platform device in a Xen PV guests causes an IRQ conflict because these guests do not have a legacy PIC. In a single VCPU Xen PV guest we should have: /proc/interrupts: CPU0 0: 4934 xen-percpu-virq timer0 1: 0 xen-percpu-ipi spinlock0

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

>>> On 09.12.15 at 15:32, wrote: > --- a/arch/x86/kernel/rtc.c > +++ b/arch/x86/kernel/rtc.c > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) > } > #endif > > + if (paravirt_enabled()) > + return -ENODEV; What about Xen Dom0? Jan

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) } #endif + if (paravirt_enabled()) + return -ENODEV;

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

Sander Eikelenboom writes: > On 2015-12-09 15:42, Jan Beulich wrote: > On 09.12.15 at 15:32, wrote: >>> --- a/arch/x86/kernel/rtc.c >>> +++ b/arch/x86/kernel/rtc.c >>> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) >>> } >>>

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

>>> On 09.12.15 at 16:15, wrote: > On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: >> On 2015-12-09 15:42, Jan Beulich wrote: >> On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c @@

Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device

On 12/09/2015 10:27 AM, Jan Beulich wrote: On 09.12.15 at 16:15, wrote: On 12/09/2015 10:00 AM, Sander Eikelenboom wrote: On 2015-12-09 15:42, Jan Beulich wrote: On 09.12.15 at 15:32, wrote: --- a/arch/x86/kernel/rtc.c +++