Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-02-01 Thread Borislav Petkov
On Fri, Feb 01, 2019 at 07:18:35PM +, Luck, Tony wrote: > For now. But very soon we will also have ARM_CPU_RESCTRL, and some of > this code will become generic. Will we need an arch-independent name for the > bits of code shared by arm and x86? Yes. The idea still is to have the

RE: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-02-01 Thread Luck, Tony
>> What about >> >> s/X86_RESCTRL/X86_CPU_RESCTRL/g > > Good idea. > > Tony, Babu, that look okay to you guys as well? For now. But very soon we will also have ARM_CPU_RESCTRL, and some of this code will become generic. Will we need an arch-independent name for the bits of code shared by arm

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-30 Thread Johannes Weiner
On Wed, Jan 30, 2019 at 06:19:33PM +0100, Borislav Petkov wrote: > On Wed, Jan 30, 2019 at 11:46:26AM -0500, Johannes Weiner wrote: > > This is still awefully close to the cgroup CPU resource > > controller. Since it's more hardware-specific, and the config symbol > > also has the x86 in it, how

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-30 Thread Borislav Petkov
On Wed, Jan 30, 2019 at 11:46:26AM -0500, Johannes Weiner wrote: > This is still awefully close to the cgroup CPU resource > controller. Since it's more hardware-specific, and the config symbol > also has the x86 in it, how about "x86 CPU resource control support"? Fine by me. What about

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-30 Thread Johannes Weiner
awefully close to the cgroup CPU resource controller. Since it's more hardware-specific, and the config symbol also has the x86 in it, how about "x86 CPU resource control support"? --- >From 2a24f6e30ed9dbc0abb96c73ec0e205e07034383 Mon Sep 17 00:00:00 2001 From: Johannes Weiner D

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-29 Thread Luck, Tony
On Wed, Jan 30, 2019 at 12:08:45AM +0100, Borislav Petkov wrote: > On Tue, Jan 29, 2019 at 05:52:18PM -0500, Johannes Weiner wrote: > > config X86_RESCTRL > > - bool "Resource Control support" > > + bool "x86 cache control support" > > Except that it is not only cache but memory (bandwidth)

Re: [PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-29 Thread Borislav Petkov
On Tue, Jan 29, 2019 at 05:52:18PM -0500, Johannes Weiner wrote: > "Resource Control" is a very broad term for this CPU feature, and a > term that is also associated with containers, cgroups etc. This can > easily cause confusion. > > Make the user prompt more specific. > > Signed-off-by:

[PATCH] x86: avoid confusion over the new RESCTRL config prompt

2019-01-29 Thread Johannes Weiner
"Resource Control" is a very broad term for this CPU feature, and a term that is also associated with containers, cgroups etc. This can easily cause confusion. Make the user prompt more specific. Signed-off-by: Johannes Weiner --- arch/x86/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2