Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-28 Thread Sam Ravnborg
On Sun, May 27, 2007 at 11:56:21AM +0200, Andi Kleen wrote: > > > > > So section mismatch warnings are more about catching sloopy usage of __init > > than it is to > > catch potential kernel oopesen. But the latter is a nice side effect that > > is appreciated. > > My point was that I cannot r

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-27 Thread Andrew Morton
On Sun, 27 May 2007 11:56:21 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > So section mismatch warnings are more about catching sloopy usage of __init > > than it is to > > catch potential kernel oopesen. But the latter is a nice side effect that > > is appreciated. > > My point was t

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-27 Thread Andi Kleen
> The whole purpose with __init and friends are the possibility to drop > the .init.text (+ .init.data) section when the kernel is up and running. I know what they do, you don't need to repeatedly reexplain them. My point was just that in all the __init/__initdata warnings I recently fixed perso

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-27 Thread Andi Kleen
> > So section mismatch warnings are more about catching sloopy usage of __init > than it is to > catch potential kernel oopesen. But the latter is a nice side effect that is > appreciated. My point was that I cannot recall a single real oops bug found by the compile time checking. We had a f

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-27 Thread Sam Ravnborg
On Sat, May 26, 2007 at 06:02:08PM +0200, Andi Kleen wrote: > On Saturday 26 May 2007 14:07:24 Indan Zupancic wrote: > > > > > Did the patches reach 2.6.22-rc3 yet? > > No. > > > > > If they did, then the following warnings might need fixing: > > There is already one patch queued for it. But

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-26 Thread Andi Kleen
On Saturday 26 May 2007 14:07:24 Indan Zupancic wrote: > > Did the patches reach 2.6.22-rc3 yet? No. > > If they did, then the following warnings might need fixing: There is already one patch queued for it. But actually in my experience I cannot remember a single real bug showed by these warn

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-26 Thread Indan Zupancic
On Mon, May 21, 2007 17:11, Sam Ravnborg wrote: > On Mon, May 21, 2007 at 02:52:39PM +0100, Jeremy Fitzhardinge wrote: >> Sam Ravnborg wrote: >> > There was another patch that removed the __init marker to _fix_ section >> > mismatch errors. >> > I have lost the actual mail but I asked the submitte

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-21 Thread Sam Ravnborg
On Mon, May 21, 2007 at 02:52:39PM +0100, Jeremy Fitzhardinge wrote: > Sam Ravnborg wrote: > > There was another patch that removed the __init marker to _fix_ section > > mismatch errors. > > I have lost the actual mail but I asked the submitter to send me a copy of > > the configuration so I coul

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-21 Thread Jeremy Fitzhardinge
Sam Ravnborg wrote: > There was another patch that removed the __init marker to _fix_ section > mismatch errors. > I have lost the actual mail but I asked the submitter to send me a copy of > the configuration so I could take a closer look. > Obviously it was the wrong fix to remove the _init mark

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-21 Thread Sam Ravnborg
On Mon, May 21, 2007 at 03:48:28PM +0200, Sam Ravnborg wrote: > On Mon, May 21, 2007 at 02:39:31PM +0100, Jeremy Fitzhardinge wrote: > > Andi Kleen wrote: > > > On Saturday 19 May 2007 15:32, Sam Ravnborg wrote: > > > > > >> Following section mismatch warnings were reported by Andrey Borzenkov:

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-21 Thread Sam Ravnborg
On Mon, May 21, 2007 at 02:39:31PM +0100, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > > On Saturday 19 May 2007 15:32, Sam Ravnborg wrote: > > > >> Following section mismatch warnings were reported by Andrey Borzenkov: > >> > > > > In what configuration? I don't see this. > > I'm pret

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > On Saturday 19 May 2007 15:32, Sam Ravnborg wrote: > >> Following section mismatch warnings were reported by Andrey Borzenkov: >> > > In what configuration? I don't see this. I'm pretty sure I made those functions __init when I cleaned up that code. Did those pieces of

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-19 Thread Sam Ravnborg
On Sat, May 19, 2007 at 03:55:49PM +0200, Andi Kleen wrote: > On Saturday 19 May 2007 15:32, Sam Ravnborg wrote: > > Following section mismatch warnings were reported by Andrey Borzenkov: > > In what configuration? I don't see this. I assumed that enabling CONFIG_MTRR would be enough to trigger it

Re: [PATCH] x86: fix section mismatch warnings in mtrr

2007-05-19 Thread Andi Kleen
On Saturday 19 May 2007 15:32, Sam Ravnborg wrote: > Following section mismatch warnings were reported by Andrey Borzenkov: In what configuration? I don't see this. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

[PATCH] x86: fix section mismatch warnings in mtrr

2007-05-19 Thread Sam Ravnborg
Following section mismatch warnings were reported by Andrey Borzenkov: WARNING: arch/i386/kernel/built-in.o - Section mismatch: reference to .init.text:amd_init_mtrr from .text between 'mtrr_bp_init' (at offset 0x967a) and 'mtrr_attrib_to_str' WARNING: arch/i386/kernel/built-in.o - Section misma