Re: [PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-05 Thread Daniel Xu
On Fri, Mar 05, 2021 at 01:32:44PM -0600, Josh Poimboeuf wrote: > On Fri, Mar 05, 2021 at 11:25:15AM -0800, Daniel Xu wrote: > > > BTW, is this a regression? or CONFIG_UNWINDER_ORC has this issue before? > > > It seems that the above commit just changed the default unwinder. This > > > means > > >

Re: [PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-05 Thread Josh Poimboeuf
On Fri, Mar 05, 2021 at 11:25:15AM -0800, Daniel Xu wrote: > > BTW, is this a regression? or CONFIG_UNWINDER_ORC has this issue before? > > It seems that the above commit just changed the default unwinder. This means > > OCR stack unwinder has this bug before that commit. > > I see your point -- I

Re: [PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-05 Thread Daniel Xu
On Fri, Mar 05, 2021 at 07:58:09PM +0900, Masami Hiramatsu wrote: > On Fri, 5 Mar 2021 18:28:06 +0900 > Masami Hiramatsu wrote: > > > Hi Daniel, > > > > On Thu, 4 Mar 2021 16:07:52 -0800 > > Daniel Xu wrote: > > > > > Getting a stack trace from inside a kretprobe used to work with frame > > >

Re: [PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-05 Thread Masami Hiramatsu
On Fri, 5 Mar 2021 18:28:06 +0900 Masami Hiramatsu wrote: > Hi Daniel, > > On Thu, 4 Mar 2021 16:07:52 -0800 > Daniel Xu wrote: > > > Getting a stack trace from inside a kretprobe used to work with frame > > pointer stack walks. After the default unwinder was switched to ORC, > > stack traces

Re: [PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-05 Thread Masami Hiramatsu
Hi Daniel, On Thu, 4 Mar 2021 16:07:52 -0800 Daniel Xu wrote: > Getting a stack trace from inside a kretprobe used to work with frame > pointer stack walks. After the default unwinder was switched to ORC, > stack traces broke because ORC did not know how to skip the > `kretprobe_trampoline` "fr

[PATCH] x86: kprobes: orc: Fix ORC walks in kretprobes

2021-03-04 Thread Daniel Xu
Getting a stack trace from inside a kretprobe used to work with frame pointer stack walks. After the default unwinder was switched to ORC, stack traces broke because ORC did not know how to skip the `kretprobe_trampoline` "frame". Frame based stack walks used to work with kretprobes because `kretp