Re: [PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long

2013-11-20 Thread Frederic Weisbecker
On Tue, Nov 19, 2013 at 08:21:45PM +0100, Oleg Nesterov wrote: > DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the unwanted > bits in the "unsigned long" data, but "ulong &= ~int" also clears the > upper bits that are not specified in mask. > > This is actually fine, dr6[32:63] are reserv

[PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long

2013-11-19 Thread Oleg Nesterov
DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the unwanted bits in the "unsigned long" data, but "ulong &= ~int" also clears the upper bits that are not specified in mask. This is actually fine, dr6[32:63] are reserved, but this is not clear so it would be better to make them "unsigned lo

Re: [PATCH] x86: make DR6_RESERVED/DR_CONTROL_RESERVED unsigned long

2013-11-19 Thread Oleg Nesterov
On 11/19, Oleg Nesterov wrote: > > DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the unwanted > bits in the "unsigned long" data, but "ulong &= ~int" also clears the > upper bits that are not specified in mask. > > This is actually fine, dr6[32:63] are reserved, but this is not clear > so