Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2015-02-02 Thread Borislav Petkov
On Fri, Jan 23, 2015 at 12:03:35PM +0100, Borislav Petkov wrote: > I've uploaded it as a branch if you want to give it a run as there are > other changes to MCE pending for 3.20 which might cause merge conflicts: > > git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git, branch mce-fb > > Shout

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2015-01-23 Thread Borislav Petkov
On Wed, Dec 17, 2014 at 10:19:12PM +0100, Borislav Petkov wrote: > Ok, thanks. I'll try to give it a run once I get a quiet minute from > all the CVE fun recently. Ok, I think we have something which shapes up to be a good simplification for the storm code and cleans up a bunch of stuff in that ar

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-17 Thread Borislav Petkov
On Tue, Dec 16, 2014 at 04:17:11PM -0800, Calvin Owens wrote: > > Right, I guess we could do something similar to what you proposed > > already (diff below ontop of my previous diff). > > That looks good, thanks :) Ok, thanks. I'll try to give it a run once I get a quiet minute from all the CVE f

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-16 Thread Calvin Owens
On Thursday 12/11 at 15:43 +0100, Borislav Petkov wrote: > On Wed, Dec 10, 2014 at 06:34:38PM -0800, Calvin Owens wrote: > > This doens't fix the original issue though: the timer double-add can > > still happen if the CMCI interrupt that hits the STORM threshold pops > > off during mce_timer_fn() a

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-11 Thread Borislav Petkov
On Wed, Dec 10, 2014 at 06:34:38PM -0800, Calvin Owens wrote: > This doens't fix the original issue though: the timer double-add can > still happen if the CMCI interrupt that hits the STORM threshold pops > off during mce_timer_fn() and calls mce_timer_kick(). Right, I guess we could do something

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-10 Thread Calvin Owens
On Wednesday 12/10 at 20:23 +0100, Borislav Petkov wrote: > On Tue, Dec 09, 2014 at 07:11:02PM -0800, Calvin Owens wrote: > > Just to make sure I understand what you're looking for: > > > > When MCE is initialized, spawn a kthread for each CPU instead of the > > current timers. If CMCI is supporte

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-10 Thread Borislav Petkov
On Tue, Dec 09, 2014 at 07:11:02PM -0800, Calvin Owens wrote: > Just to make sure I understand what you're looking for: > > When MCE is initialized, spawn a kthread for each CPU instead of the > current timers. If CMCI is supported, we just leave this thread parked, > and only process errors from

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-09 Thread Calvin Owens
On Tuesday 12/09 at 23:00 +, Luck, Tony wrote: > > Right, so this polling thing once again proves its fragility to me - we > > have had problems with it in the past so maybe we should think about > > replacing it with something simpler and and much more robust instead of > > this flaky dynamica

RE: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-09 Thread Luck, Tony
> Right, so this polling thing once again proves its fragility to me - we > have had problems with it in the past so maybe we should think about > replacing it with something simpler and and much more robust instead of > this flaky dynamically adjustable polling thing. Dynamic intervals for pollin

Re: [PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-09 Thread Borislav Petkov
On Thu, Dec 04, 2014 at 06:29:35PM -0800, Calvin Owens wrote: > The Intel CMCI interrupt handler calls mce_timer_kick() to force more > frequent polling for MCE events when a CMCI storm occurs and CMCI > interrupts are subsequently disabled. > > If a CMCI interrupt storm happens to be detected whi

[PATCH] x86: mce: Avoid timer double-add during CMCI interrupt storms.

2014-12-04 Thread Calvin Owens
The Intel CMCI interrupt handler calls mce_timer_kick() to force more frequent polling for MCE events when a CMCI storm occurs and CMCI interrupts are subsequently disabled. If a CMCI interrupt storm happens to be detected while the timer interrupt is executing timer functions, mce_timer_kick() ca