Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-13 Thread Christoph Lameter
On Wed, 11 Jun 2014, David Rientjes wrote: > > > Yes, but the question is: why? > > > > zones need to be aligned so that the huge pages order and other page > > orders allocated from the page allocator are at their "natural alignment". > > Otherwise huge pages cannot be mapped properly and various

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-11 Thread David Rientjes
On Wed, 11 Jun 2014, Christoph Lameter wrote: > > > The zone should not cross the 8M boundary? > > > > Yes, but the question is: why? > > zones need to be aligned so that the huge pages order and other page > orders allocated from the page allocator are at their "natural alignment". > Otherwise h

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-11 Thread Christoph Lameter
On Wed, 11 Jun 2014, Luiz Capitulino wrote: > > The zone should not cross the 8M boundary? > > Yes, but the question is: why? zones need to be aligned so that the huge pages order and other page orders allocated from the page allocator are at their "natural alignment". Otherwise huge pages cannot

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-11 Thread Luiz Capitulino
Yinghai, sorry for my late reply. On Mon, 9 Jun 2014 15:13:41 -0700 Yinghai Lu wrote: > On Mon, Jun 9, 2014 at 12:03 PM, Luiz Capitulino > wrote: > > On Sun, 8 Jun 2014 18:29:11 -0700 > > Yinghai Lu wrote: > > > >> On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino > >> wrote: > > [0.

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-10 Thread Luiz Capitulino
On Tue, 10 Jun 2014 15:10:01 -0700 (PDT) David Rientjes wrote: > On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > > > > > diff --git a/arch/x86/include/asm/numa.h > > > > > > b/arch/x86/include/asm/numa.h > > > > > > index 4064aca..01b493e 100644 > > > > > > --- a/arch/x86/include/asm/numa.h >

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-10 Thread David Rientjes
On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > > > > index 4064aca..01b493e 100644 > > > > > --- a/arch/x86/include/asm/numa.h > > > > > +++ b/arch/x86/include/asm/numa.h > > > > > @@ -9,7 +9,6 @@ > > > > > #ifdef CO

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-09 Thread Luiz Capitulino
On Mon, 9 Jun 2014 14:57:16 -0700 (PDT) David Rientjes wrote: > On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > > > index 4064aca..01b493e 100644 > > > > --- a/arch/x86/include/asm/numa.h > > > > +++ b/arch/x86/inclu

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-09 Thread Yinghai Lu
On Mon, Jun 9, 2014 at 12:03 PM, Luiz Capitulino wrote: > On Sun, 8 Jun 2014 18:29:11 -0700 > Yinghai Lu wrote: > >> On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino >> wrote: > [0.00] e820: BIOS-provided physical RAM map: > [0.00] BIOS-e820: [mem 0x-0x000

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-09 Thread David Rientjes
On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > > index 4064aca..01b493e 100644 > > > --- a/arch/x86/include/asm/numa.h > > > +++ b/arch/x86/include/asm/numa.h > > > @@ -9,7 +9,6 @@ > > > #ifdef CONFIG_NUMA > > > > > >

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-09 Thread Luiz Capitulino
On Sun, 8 Jun 2014 18:29:11 -0700 Yinghai Lu wrote: > On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino > wrote: > > In short, I believe this is just dead code for the upstream kernel but this > > causes a bug for 2.6.32 based kernels. > > > > The setup_node_data() function is used to initialize

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-09 Thread Luiz Capitulino
On Sun, 8 Jun 2014 15:25:50 -0700 (PDT) David Rientjes wrote: > On Sun, 8 Jun 2014, Luiz Capitulino wrote: > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > index 4064aca..01b493e 100644 > > --- a/arch/x86/include/asm/numa.h > > +++ b/arch/x86/include/asm/numa.h >

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-08 Thread Yinghai Lu
On Sun, Jun 8, 2014 at 3:14 PM, Luiz Capitulino wrote: > In short, I believe this is just dead code for the upstream kernel but this > causes a bug for 2.6.32 based kernels. > > The setup_node_data() function is used to initialize NODE_DATA() for a node. > It gets a node id and a memory range. The

Re: [PATCH] x86: numa: drop ZONE_ALIGN

2014-06-08 Thread David Rientjes
On Sun, 8 Jun 2014, Luiz Capitulino wrote: > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > index 4064aca..01b493e 100644 > --- a/arch/x86/include/asm/numa.h > +++ b/arch/x86/include/asm/numa.h > @@ -9,7 +9,6 @@ > #ifdef CONFIG_NUMA > > #define NR_NODE_MEMBLKS

[PATCH] x86: numa: drop ZONE_ALIGN

2014-06-08 Thread Luiz Capitulino
In short, I believe this is just dead code for the upstream kernel but this causes a bug for 2.6.32 based kernels. The setup_node_data() function is used to initialize NODE_DATA() for a node. It gets a node id and a memory range. The start address for the memory range is rounded up to ZONE_ALIGN a