Re: [PATCH] x86: optionally show last exception from/to register contents (v2)

2007-09-01 Thread Andi Kleen
On Tuesday 28 August 2007 12:44:31 Jan Beulich wrote: > .. when dumping register state. This is particularly useful when gcc > managed to tail-call optimize an indirect call which happens to hit a > NULL (or otherwise invalid) pointer. I added it, with a warning in the documentation and changelog

[PATCH] x86: optionally show last exception from/to register contents (v2)

2007-08-28 Thread Jan Beulich
.. when dumping register state. This is particularly useful when gcc managed to tail-call optimize an indirect call which happens to hit a NULL (or otherwise invalid) pointer. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> Documentation/kernel-parameters.txt |3 +++ arch/i386/kernel/cpu/amd.

Re: [PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Randy Dunlap
On Mon, 13 Aug 2007 16:21:10 +0200 Andi Kleen wrote: > > I though you did, but since I never saw it appear in any release, I posted > > this one... > > It's a little different (and somewhat hackish I admit) > ftp://firstfloor.org/pub/ak/x86_64/debug/last-branch > It has far more overhead than yo

Re: [PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Keith Owens
Andi Kleen (on Mon, 13 Aug 2007 15:08:45 +0200) wrote: >On Mon, Aug 13, 2007 at 12:33:05PM +0100, Jan Beulich wrote: > > >> >> if (cpu_has_ds) { >> unsigned int l1; >> --- linux-2.6.23-rc3/arch/i386/kernel/traps.c2007-08-13 >> 08:59:45.0 +0200 >> +++ 2.6.23-rc3-

Re: [PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Andi Kleen
> I though you did, but since I never saw it appear in any release, I posted > this one... It's a little different (and somewhat hackish I admit) ftp://firstfloor.org/pub/ak/x86_64/debug/last-branch It has far more overhead than yours of course. The only way to merge something like that would be

Re: [PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Jan Beulich
>>> Andi Kleen <[EMAIL PROTECTED]> 13.08.07 15:08 >>> >On Mon, Aug 13, 2007 at 12:33:05PM +0100, Jan Beulich wrote: >> +if (__get_cpu_var(ler_msr)) { >> +u32 from, to, hi; >> + >> +rdmsr(__get_cpu_var(ler_msr), from, hi); >> +r

Re: [PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Andi Kleen
On Mon, Aug 13, 2007 at 12:33:05PM +0100, Jan Beulich wrote: > > if (cpu_has_ds) { > unsigned int l1; > --- linux-2.6.23-rc3/arch/i386/kernel/traps.c 2007-08-13 08:59:45.0 > +0200 > +++ 2.6.23-rc3-x86-ler/arch/i386/kernel/traps.c 2007-08-07 > 10:42:55.000

[PATCH] x86: optionally show last exception from/to register contents

2007-08-13 Thread Jan Beulich
.. when dumping register state. This is particularly useful when gcc managed to tail-call optimize an indirect call which happens to hit a NULL (or otherwise invalid) pointer. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> arch/i386/kernel/cpu/amd.c |4 arch/i386/kernel/cpu/common.c