Re: [PATCH] x86: svm: don't intercept CR0 TS or MP bit write

2015-02-25 Thread Joel Schopp
On 02/25/2015 02:26 PM, Radim Krčmář wrote: > 2015-02-24 15:25-0600, Joel Schopp: - clr_cr_intercept(svm, INTERCEPT_CR0_WRITE); } else { set_cr_intercept(svm, INTERCEPT_CR0_READ); >>> (There is no point in checking fpu_active if cr0s are equal.) >>> -

Re: [PATCH] x86: svm: don't intercept CR0 TS or MP bit write

2015-02-25 Thread Radim Krčmář
2015-02-24 15:25-0600, Joel Schopp: > > >> - clr_cr_intercept(svm, INTERCEPT_CR0_WRITE); > >>} else { > >>set_cr_intercept(svm, INTERCEPT_CR0_READ); > > (There is no point in checking fpu_active if cr0s are equal.) > > > >> - set_cr_intercept(svm, INTERCEPT_CR0_WR

Re: [PATCH] x86: svm: don't intercept CR0 TS or MP bit write

2015-02-24 Thread Joel Schopp
>> -clr_cr_intercept(svm, INTERCEPT_CR0_WRITE); >> } else { >> set_cr_intercept(svm, INTERCEPT_CR0_READ); > (There is no point in checking fpu_active if cr0s are equal.) > >> -set_cr_intercept(svm, INTERCEPT_CR0_WRITE); > KVM uses lazy FPU and the state is

Re: [PATCH] x86: svm: don't intercept CR0 TS or MP bit write

2015-02-23 Thread Radim Krčmář
2015-02-20 16:44-0600, Joel Schopp: > From: David Kaplan > > Reduce the number of exits by avoiding exiting when the guest writes TS or MP > bits of CR0. INTERCEPT_CR0_WRITE intercepts all writes to CR0 including TS > and > MP bits. It intercepts these even if INTERCEPT_SELECTIVE_CR0 is set. W

[PATCH] x86: svm: don't intercept CR0 TS or MP bit write

2015-02-20 Thread Joel Schopp
From: David Kaplan Reduce the number of exits by avoiding exiting when the guest writes TS or MP bits of CR0. INTERCEPT_CR0_WRITE intercepts all writes to CR0 including TS and MP bits. It intercepts these even if INTERCEPT_SELECTIVE_CR0 is set. What we should be doing is setting INTERCEPT_SELEC