Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-30 Thread Seunghun Han
> > On Thu, Aug 29, 2019 at 06:34:37PM +0300, Jarkko Sakkinen wrote: > > > On Wed, Aug 28, 2019 at 06:36:04PM +0900, Seunghun Han wrote: > > > > > > > > > > On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > > > > > > > > > > > I got your point. Is there any problem if some regions

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-29 Thread Seunghun Han
> > On Thu, Aug 29, 2019 at 06:34:37PM +0300, Jarkko Sakkinen wrote: > > On Wed, Aug 28, 2019 at 06:36:04PM +0900, Seunghun Han wrote: > > > > > > > > On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > > > > > > > > > I got your point. Is there any problem if some regions which don't

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-29 Thread Jarkko Sakkinen
On Thu, Aug 29, 2019 at 06:34:37PM +0300, Jarkko Sakkinen wrote: > On Wed, Aug 28, 2019 at 06:36:04PM +0900, Seunghun Han wrote: > > > > > > On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > > > > > > > I got your point. Is there any problem if some regions which don't > > > > need

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-29 Thread Jarkko Sakkinen
On Wed, Aug 28, 2019 at 06:36:04PM +0900, Seunghun Han wrote: > > > > On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > > > > > I got your point. Is there any problem if some regions which don't > > > need to be handled in NVS area are saved and restored? If there is a > > > problem,

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-28 Thread Seunghun Han
> > On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > > > I got your point. Is there any problem if some regions which don't > > need to be handled in NVS area are saved and restored? If there is a > > problem, how about adding code for ignoring the regions in NVS area to > > the

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Matthew Garrett
On Wed, Aug 28, 2019 at 01:36:30AM +0900, Seunghun Han wrote: > I got your point. Is there any problem if some regions which don't > need to be handled in NVS area are saved and restored? If there is a > problem, how about adding code for ignoring the regions in NVS area to > the nvs.c file like

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Seunghun Han
> On Tue, Aug 27, 2019 at 1:23 AM Seunghun Han wrote: > > If the regions allocated in the NVS region need to be handled by a > > driver, the callback mechanism is good for it. However, this case > > doesn't need it because the regions allocated in NVS are just I/O > > regions. > > > > In my

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Matthew Garrett
On Tue, Aug 27, 2019 at 1:23 AM Seunghun Han wrote: > If the regions allocated in the NVS region need to be handled by a > driver, the callback mechanism is good for it. However, this case > doesn't need it because the regions allocated in NVS are just I/O > regions. > > In my opinion, if the

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Seunghun Han
> > On Mon, Aug 26, 2019 at 10:40:25AM -0700, Matthew Garrett wrote: > > On Mon, Aug 26, 2019 at 1:18 AM Seunghun Han wrote: > > > To support AMD's fTPM, I removed the busy bit from the ACPI NVS area like > > > the reserved area so that AMD's fTPM regions could be assigned in it. > > > >

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Jarkko Sakkinen
On Mon, Aug 26, 2019 at 10:40:25AM -0700, Matthew Garrett wrote: > On Mon, Aug 26, 2019 at 1:18 AM Seunghun Han wrote: > > To support AMD's fTPM, I removed the busy bit from the ACPI NVS area like > > the reserved area so that AMD's fTPM regions could be assigned in it. > > drivers/acpi/nvs.c

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-27 Thread Seunghun Han
> > On Mon, Aug 26, 2019 at 1:18 AM Seunghun Han wrote: > > To support AMD's fTPM, I removed the busy bit from the ACPI NVS area like > > the reserved area so that AMD's fTPM regions could be assigned in it. > > drivers/acpi/nvs.c saves and restores the contents of NVS regions, and > if other

Re: [PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-26 Thread Matthew Garrett
On Mon, Aug 26, 2019 at 1:18 AM Seunghun Han wrote: > To support AMD's fTPM, I removed the busy bit from the ACPI NVS area like > the reserved area so that AMD's fTPM regions could be assigned in it. drivers/acpi/nvs.c saves and restores the contents of NVS regions, and if other drivers use

[PATCH] x86: tpm: Remove a busy bit of the NVS area for supporting AMD's fTPM

2019-08-26 Thread Seunghun Han
I'm Seunghun Han and work at the Affiliated Institute of ETRI. I got an AMD system which had a Ryzen Threadripper 1950X and MSI mainboard, and I had a problem with AMD's fTPM. My machine showed an error message below, and the fTPM didn't work because of it. [  5.732084] tpm_crb MSFT0101:00: can't