Re: [PATCH] x86: uv: Fix potential NULL pointer dereference of kmalloc_node

2019-03-04 Thread Peter Zijlstra
On Sat, Mar 02, 2019 at 03:09:04PM -0600, Aditya Pakki wrote: > kmalloc_node might fail to allocate memory for thp field. This fix > attempts to avoid a potential NULL pointer dereference. > > Signed-off-by: Aditya Pakki > --- > arch/x86/platform/uv/tlb_uv.c | 3 +++ > 1 file changed, 3 insertio

Re: [PATCH] x86: uv: Fix potential NULL pointer dereference of kmalloc_node

2019-03-02 Thread Gustavo A. R. Silva
Hi Aditya, On 3/2/19 3:09 PM, Aditya Pakki wrote: > kmalloc_node might fail to allocate memory for thp field. This fix > attempts to avoid a potential NULL pointer dereference. > If this was detected by any static analyzer, please mention the tool in the commit log. Also, notice that this code d

Re: [PATCH] x86: uv: Fix potential NULL pointer dereference of kmalloc_node

2019-03-02 Thread Joe Perches
On Sat, 2019-03-02 at 15:09 -0600, Aditya Pakki wrote: > kmalloc_node might fail to allocate memory for thp field. This fix > attempts to avoid a potential NULL pointer dereference. right > diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c [] > @@ -2011,6 +2011,9 @@ stati

[PATCH] x86: uv: Fix potential NULL pointer dereference of kmalloc_node

2019-03-02 Thread Aditya Pakki
kmalloc_node might fail to allocate memory for thp field. This fix attempts to avoid a potential NULL pointer dereference. Signed-off-by: Aditya Pakki --- arch/x86/platform/uv/tlb_uv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb