Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Ingo Molnar
* Pavel Machek wrote: > On Thu 2018-07-26 13:45:37, Ingo Molnar wrote: > > > > * Pavel Machek wrote: > > > > > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > > > >>> On 25.06.18 at 18:33, wrote: > > > > > > On 06/25/2018

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Ingo Molnar
* Pavel Machek wrote: > On Thu 2018-07-26 13:45:37, Ingo Molnar wrote: > > > > * Pavel Machek wrote: > > > > > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > > > >>> On 25.06.18 at 18:33, wrote: > > > > > > On 06/25/2018

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Pavel Machek
On Thu 2018-07-26 13:45:37, Ingo Molnar wrote: > > * Pavel Machek wrote: > > > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > > >>> On 25.06.18 at 18:33, wrote: > > > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > > > >>

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Pavel Machek
On Thu 2018-07-26 13:45:37, Ingo Molnar wrote: > > * Pavel Machek wrote: > > > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > > >>> On 25.06.18 at 18:33, wrote: > > > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > > > >>

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Ingo Molnar
* Pavel Machek wrote: > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > >>> On 25.06.18 at 18:33, wrote: > > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms -

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Ingo Molnar
* Pavel Machek wrote: > On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > > On Tue, 26 Jun 2018, Jan Beulich wrote: > > > >>> On 25.06.18 at 18:33, wrote: > > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms -

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Pavel Machek
On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > On Tue, 26 Jun 2018, Jan Beulich wrote: > > >>> On 25.06.18 at 18:33, wrote: > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > > >> 32-bit ones instead. > >

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-07-26 Thread Pavel Machek
On Tue 2018-06-26 08:38:22, Henrique de Moraes Holschuh wrote: > On Tue, 26 Jun 2018, Jan Beulich wrote: > > >>> On 25.06.18 at 18:33, wrote: > > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > > >> 32-bit ones instead. > >

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Henrique de Moraes Holschuh
On Tue, 26 Jun 2018, Jan Beulich wrote: > >>> On 25.06.18 at 18:33, wrote: > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > >> 32-bit ones instead. > > > > Hmph. Is that considered a bug (errata)? > > No. > > >

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Henrique de Moraes Holschuh
On Tue, 26 Jun 2018, Jan Beulich wrote: > >>> On 25.06.18 at 18:33, wrote: > > On 06/25/2018 03:25 AM, Jan Beulich wrote: > >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > >> 32-bit ones instead. > > > > Hmph. Is that considered a bug (errata)? > > No. > > >

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Ingo Molnar
* Jan Beulich wrote: > Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms Please write out the consequence of that in the changelog. Thanks, Ingo

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Ingo Molnar
* Jan Beulich wrote: > Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms Please write out the consequence of that in the changelog. Thanks, Ingo

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Jan Beulich
>>> On 25.06.18 at 18:33, wrote: > On 06/25/2018 03:25 AM, Jan Beulich wrote: >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use >> 32-bit ones instead. > > Hmph. Is that considered a bug (errata)? No. > URL/references? Intel's Optimization Reference Manual says so (in

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-26 Thread Jan Beulich
>>> On 25.06.18 at 18:33, wrote: > On 06/25/2018 03:25 AM, Jan Beulich wrote: >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use >> 32-bit ones instead. > > Hmph. Is that considered a bug (errata)? No. > URL/references? Intel's Optimization Reference Manual says so (in

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread hpa
On June 25, 2018 9:33:35 AM PDT, Randy Dunlap wrote: >On 06/25/2018 03:25 AM, Jan Beulich wrote: >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use >> 32-bit ones instead. > >Hmph. Is that considered a bug (errata)? > >URL/references? > >Are these changes really only zeroing

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread hpa
On June 25, 2018 9:33:35 AM PDT, Randy Dunlap wrote: >On 06/25/2018 03:25 AM, Jan Beulich wrote: >> Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use >> 32-bit ones instead. > >Hmph. Is that considered a bug (errata)? > >URL/references? > >Are these changes really only zeroing

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread Randy Dunlap
On 06/25/2018 03:25 AM, Jan Beulich wrote: > Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > 32-bit ones instead. Hmph. Is that considered a bug (errata)? URL/references? Are these changes really only zeroing the lower 32 bits of the register? and that's all that the code

Re: [PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread Randy Dunlap
On 06/25/2018 03:25 AM, Jan Beulich wrote: > Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use > 32-bit ones instead. Hmph. Is that considered a bug (errata)? URL/references? Are these changes really only zeroing the lower 32 bits of the register? and that's all that the code

[PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread Jan Beulich
Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use 32-bit ones instead. Signed-off-by: Jan Beulich --- arch/x86/crypto/aegis128-aesni-asm.S |2 +- arch/x86/crypto/aegis128l-aesni-asm.S|2 +- arch/x86/crypto/aegis256-aesni-asm.S |2 +-

[PATCH] x86-64: use 32-bit XOR to zero registers

2018-06-25 Thread Jan Beulich
Some Intel CPUs don't recognize 64-bit XORs as zeroing idioms - use 32-bit ones instead. Signed-off-by: Jan Beulich --- arch/x86/crypto/aegis128-aesni-asm.S |2 +- arch/x86/crypto/aegis128l-aesni-asm.S|2 +- arch/x86/crypto/aegis256-aesni-asm.S |2 +-