Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-14 Thread Rafael J. Wysocki
On Tuesday, June 14, 2016 08:06:49 PM chenyu wrote: > On Mon, Jun 13, 2016 at 9:42 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Logan Gunthorpe reports that hibernation stopped working reliably for > > him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table > >

Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-14 Thread chenyu
On Mon, Jun 13, 2016 at 9:42 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Logan Gunthorpe reports that hibernation stopped working reliably for > him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table > and rodata). Most likely, what happens is that the page contai

Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-13 Thread Rafael J. Wysocki
On Tue, Jun 14, 2016 at 12:53 AM, Kees Cook wrote: > On Mon, Jun 13, 2016 at 3:15 PM, Rafael J. Wysocki wrote: >> On Monday, June 13, 2016 02:58:57 PM Kees Cook wrote: >>> On Mon, Jun 13, 2016 at 6:42 AM, Rafael J. Wysocki >>> wrote: >>> > From: Rafael J. Wysocki >>> > [cut] >>> >>> Acked-by

Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-13 Thread Kees Cook
On Mon, Jun 13, 2016 at 3:15 PM, Rafael J. Wysocki wrote: > On Monday, June 13, 2016 02:58:57 PM Kees Cook wrote: >> On Mon, Jun 13, 2016 at 6:42 AM, Rafael J. Wysocki >> wrote: >> > From: Rafael J. Wysocki >> > >> > Logan Gunthorpe reports that hibernation stopped working reliably for >> > him

Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-13 Thread Rafael J. Wysocki
On Monday, June 13, 2016 02:58:57 PM Kees Cook wrote: > On Mon, Jun 13, 2016 at 6:42 AM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Logan Gunthorpe reports that hibernation stopped working reliably for > > him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table >

Re: [PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-13 Thread Kees Cook
On Mon, Jun 13, 2016 at 6:42 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Logan Gunthorpe reports that hibernation stopped working reliably for > him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table > and rodata). Most likely, what happens is that the page contai

[PATCH] x86 / hibernate: Fix 64-bit code passing control to image kernel

2016-06-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Logan Gunthorpe reports that hibernation stopped working reliably for him after commit ab76f7b4ab23 (x86/mm: Set NX on gap between __ex_table and rodata). Most likely, what happens is that the page containing the image kernel's entry point is sometimes marked as non-execu