Re: [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
On 03/26/2015 07:15 PM, Roger Pau Monné wrote: > Hello, > > El 25/03/15 a les 11.02, Bob Liu ha escrit: >> +gnttab_unmap_refs_async(&unmap_data); >> +wait_for_completion(&unmap_completion); > > I think David had a comment about putting this into some kind of common > help

Re: [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Roger Pau Monné
Hello, El 25/03/15 a les 11.02, Bob Liu ha escrit: > + gnttab_unmap_refs_async(&unmap_data); > + wait_for_completion(&unmap_completion); I think David had a comment about putting this into some kind of common helper since it's used widely (at least in blkback). Could you l

[PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-25 Thread Bob Liu
Commit c43cf3ea8385 ("xen-blkback: safely unmap grants in case they are still in use") use gnttab_unmap_refs_async() to wait until the mapped pages are no longer in use before unmapping them, but that commit missed the persistent case. Purge persistent pages can't be unmapped either unless no longe