Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 4:19 PM, Greg KH wrote: > On Tue, Dec 10, 2013 at 04:03:41PM +0800, Ethan Zhao wrote: >> On Tue, Dec 10, 2013 at 2:40 AM, Greg KH wrote: >> > On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: >> >> Greg, >> >> I am the man who built a Xen dom0, but couldn't s

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-10 Thread Greg KH
On Tue, Dec 10, 2013 at 04:03:41PM +0800, Ethan Zhao wrote: > On Tue, Dec 10, 2013 at 2:40 AM, Greg KH wrote: > > On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: > >> Greg, > >> I am the man who built a Xen dom0, but couldn't see debugfs > >> directory and files as expected. there

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-10 Thread Ethan Zhao
On Tue, Dec 10, 2013 at 2:40 AM, Greg KH wrote: > On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: >> Greg, >> I am the man who built a Xen dom0, but couldn't see debugfs >> directory and files as expected. there is no warning or tip for me to >> enable the CONFIG_DEBUG_FS=y in .con

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote: > Greg, > I am the man who built a Xen dom0, but couldn't see debugfs > directory and files as expected. there is no warning or tip for me to > enable the CONFIG_DEBUG_FS=y in .config , it cost me minutes to figure > out what's > the m

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
Greg, I am the man who built a Xen dom0, but couldn't see debugfs directory and files as expected. there is no warning or tip for me to enable the CONFIG_DEBUG_FS=y in .config , it cost me minutes to figure out what's the matter. and I know should check defugfs config and initialization as zswa

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 06:04:03PM +0800, Ethan Zhao wrote: > From: "Ethan Zhao" > > Should check debugfs initialization with debugfs_initialized() before using > it, > Because if it isn't initialized, the return value of fake > debugfs_create_dir() etc > functions would be ERR_PTR(-ENODEV), ch

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 05:57:22PM +0800, Ethan Zhao wrote: > On Mon, Dec 9, 2013 at 4:55 PM, Greg KH wrote: > > On Mon, Dec 09, 2013 at 04:44:05PM +0800, Ethan Zhao wrote: > >> On Mon, Dec 9, 2013 at 4:25 PM, Greg KH wrote: > >> > On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: > >>

[PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
From: "Ethan Zhao" Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work. V3: Add warning message about debugfs not

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
On Mon, Dec 9, 2013 at 4:55 PM, Greg KH wrote: > On Mon, Dec 09, 2013 at 04:44:05PM +0800, Ethan Zhao wrote: >> On Mon, Dec 9, 2013 at 4:25 PM, Greg KH wrote: >> > On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: >> >> On Sun, Dec 8, 2013 at 10:01 PM, Greg KH >> >> wrote: >> >> > On

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 04:44:05PM +0800, Ethan Zhao wrote: > On Mon, Dec 9, 2013 at 4:25 PM, Greg KH wrote: > > On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: > >> On Sun, Dec 8, 2013 at 10:01 PM, Greg KH > >> wrote: > >> > On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Ethan Zhao
On Mon, Dec 9, 2013 at 4:25 PM, Greg KH wrote: > On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: >> On Sun, Dec 8, 2013 at 10:01 PM, Greg KH wrote: >> > On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: >> >> Should check debugfs initialization with debugfs_initialized() bef

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 09:43:16AM +0800, Ethan Zhao wrote: > On Sun, Dec 8, 2013 at 10:01 PM, Greg KH wrote: > > On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: > >> Should check debugfs initialization with debugfs_initialized() before > >> using it, > >> Because if it isn't initiali

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-08 Thread Ethan Zhao
On Sun, Dec 8, 2013 at 10:01 PM, Greg KH wrote: > On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: >> Should check debugfs initialization with debugfs_initialized() before using >> it, >> Because if it isn't initialized, the return value of fake >> debugfs_create_dir() etc >> function

Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-08 Thread Greg KH
On Sun, Dec 08, 2013 at 07:31:02PM +0800, ethan.zhao wrote: > Should check debugfs initialization with debugfs_initialized() before using > it, > Because if it isn't initialized, the return value of fake > debugfs_create_dir() etc > functions would be ERR_PTR(-ENODEV), checking with NULL will not

[PATCH] xen/debugfs: Check debugfs initialization before using it

2013-12-08 Thread ethan.zhao
Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work. Signed-off-by: ethan.zhao --- arch/x86/xen/debugfs.c | 6