Re: [PATCH] xen/netback: fix error path of xenvif_connect_data()

2019-10-19 Thread David Miller
From: Juergen Gross Date: Fri, 18 Oct 2019 09:45:49 +0200 > xenvif_connect_data() calls module_put() in case of error. This is > wrong as there is no related module_get(). > > Remove the superfluous module_put(). > > Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif

Re: [PATCH] xen/netback: fix error path of xenvif_connect_data()

2019-10-18 Thread Wei Liu
On Fri, Oct 18, 2019 at 09:45:49AM +0200, Juergen Gross wrote: > xenvif_connect_data() calls module_put() in case of error. This is > wrong as there is no related module_get(). > > Remove the superfluous module_put(). > > Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the

[PATCH] xen/netback: fix error path of xenvif_connect_data()

2019-10-18 Thread Juergen Gross
xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: # 3.12 Signed-off-by: Juergen Gross Reviewed-by: