Re: [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-03-15 Thread Shah, Amit
On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ numbe

Re: [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Juergen Gross
On 28/02/18 10:19, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ numbers. > > Note th

Re: [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Boris Ostrovsky
On 02/28/2018 04:22 AM, Shah, Amit wrote: > On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: >> Current cleanup in the error path of xen_bind_pirq_msi_to_irq is >> wrong. First of all there's an off-by-one in the cleanup loop, which >> can lead to unbinding wrong IRQs. >> >> Secondly IRQs n

Re: [PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Shah, Amit
On Mi, 2018-02-28 at 09:19 +, Roger Pau Monne wrote: > Current cleanup in the error path of xen_bind_pirq_msi_to_irq is > wrong. First of all there's an off-by-one in the cleanup loop, which > can lead to unbinding wrong IRQs. > > Secondly IRQs not bound won't be freed, thus leaking IRQ numbe

[PATCH] xen/pirq: fix error path cleanup when binding MSIs

2018-02-28 Thread Roger Pau Monne
Current cleanup in the error path of xen_bind_pirq_msi_to_irq is wrong. First of all there's an off-by-one in the cleanup loop, which can lead to unbinding wrong IRQs. Secondly IRQs not bound won't be freed, thus leaking IRQ numbers. Note that there's no need to differentiate between bound and un