Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-20 Thread Ian Campbell
On Tue, 2013-02-19 at 18:06 +, David Miller wrote: > From: Ian Campbell > Date: Tue, 19 Feb 2013 08:58:44 + > > > On Tue, 2013-02-19 at 08:03 +, Jan Beulich wrote: > >> >>> On 19.02.13 at 06:53, David Miller wrote: > >> > From: Andrew Jones > >> > Date: Mon, 18 Feb 2013 21:29:20 +01

Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-19 Thread David Miller
From: Ian Campbell Date: Tue, 19 Feb 2013 08:58:44 + > On Tue, 2013-02-19 at 08:03 +, Jan Beulich wrote: >> >>> On 19.02.13 at 06:53, David Miller wrote: >> > From: Andrew Jones >> > Date: Mon, 18 Feb 2013 21:29:20 +0100 >> > >> >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which

Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-19 Thread Ian Campbell
On Tue, 2013-02-19 at 08:03 +, Jan Beulich wrote: > The core of > it is that the put here parallels the one in netbk_tx_err(), and > the one in xenvif_carrier_off() matches the get from > xenvif_connect() (which normally would be done on the path > coming through xenvif_disconnect()). A few p

Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-19 Thread Ian Campbell
On Tue, 2013-02-19 at 08:03 +, Jan Beulich wrote: > >>> On 19.02.13 at 06:53, David Miller wrote: > > From: Andrew Jones > > Date: Mon, 18 Feb 2013 21:29:20 +0100 > > > >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does > >> a xenvif_put(). As callers of netbk_fatal_tx_err should

Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-19 Thread Andrew Jones
On Tue, 19 Feb 2013 08:03:49 + "Jan Beulich" wrote: > >>> On 19.02.13 at 06:53, David Miller wrote: > > From: Andrew Jones > > Date: Mon, 18 Feb 2013 21:29:20 +0100 > > > >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does > >> a xenvif_put(). As callers of netbk_fatal_tx_err sh

Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

2013-02-19 Thread Jan Beulich
>>> On 19.02.13 at 06:53, David Miller wrote: > From: Andrew Jones > Date: Mon, 18 Feb 2013 21:29:20 +0100 > >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does >> a xenvif_put(). As callers of netbk_fatal_tx_err should only >> have one reference to the vif at this time, then the xenv

Re: [PATCH] xen: netback: remove redundant xenvif_put

2013-02-18 Thread David Miller
From: Andrew Jones Date: Mon, 18 Feb 2013 21:29:20 +0100 > netbk_fatal_tx_err() calls xenvif_carrier_off(), which does > a xenvif_put(). As callers of netbk_fatal_tx_err should only > have one reference to the vif at this time, then the xenvif_put > in netbk_fatal_tx_err is one too many. > > Sig

[PATCH] xen: netback: remove redundant xenvif_put

2013-02-18 Thread Andrew Jones
netbk_fatal_tx_err() calls xenvif_carrier_off(), which does a xenvif_put(). As callers of netbk_fatal_tx_err should only have one reference to the vif at this time, then the xenvif_put in netbk_fatal_tx_err is one too many. Signed-off-by: Andrew Jones --- drivers/net/xen-netback/netback.c | 1 -