Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-04-01 Thread Chentao (Boby)
Thanks roger and joe. I will adopt your suggestions in my v2 patch. On 2015/3/31 22:57, Roger Pau Monné wrote: El 31/03/15 a les 23.14, Tao Chen ha escrit: Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the

Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-04-01 Thread Chentao (Boby)
Thanks roger and joe. I will adopt your suggestions in my v2 patch. On 2015/3/31 22:57, Roger Pau Monné wrote: El 31/03/15 a les 23.14, Tao Chen ha escrit: Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the

Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 16:57 +0200, Roger Pau Monné wrote: > El 31/03/15 a les 23.14, Tao Chen ha escrit: > > Define pr_fmt macro with {xen-blkback: } prefix, then remove all use > > of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. [] > > diff --git

Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Roger Pau Monné
El 31/03/15 a les 23.14, Tao Chen ha escrit: > Define pr_fmt macro with {xen-blkback: } prefix, then remove all use > of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. > > And if the pr sentences miss a \n, add it in the end. If the DPRINTK > sentences have redundant \n,

[PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Tao Chen
Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. And if the pr sentences miss a \n, add it in the end. If the DPRINTK sentences have redundant \n, remove it. It will format the code. These all make the

Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Roger Pau Monné
El 31/03/15 a les 23.14, Tao Chen ha escrit: Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. And if the pr sentences miss a \n, add it in the end. If the DPRINTK sentences have redundant \n, remove

Re: [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 16:57 +0200, Roger Pau Monné wrote: El 31/03/15 a les 23.14, Tao Chen ha escrit: Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. [] diff --git

[PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Tao Chen
Define pr_fmt macro with {xen-blkback: } prefix, then remove all use of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. And if the pr sentences miss a \n, add it in the end. If the DPRINTK sentences have redundant \n, remove it. It will format the code. These all make the