Re: [PATCH] xen-blkback: fix memory leaks

2014-01-28 Thread Roger Pau Monné
On 28/01/14 16:37, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 28, 2014 at 01:44:37PM +0100, Roger Pau Monné wrote: >> On 27/01/14 22:21, Konrad Rzeszutek Wilk wrote: >>> On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: @@ -976,17 +983,19 @@ static void __end_block_io_op(struct

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-28 Thread Konrad Rzeszutek Wilk
On Tue, Jan 28, 2014 at 01:44:37PM +0100, Roger Pau Monné wrote: > On 27/01/14 22:21, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: > >> I've at least identified two possible memory leaks in blkback, both > >> related to the shutdown path of a VBD

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-28 Thread Roger Pau Monné
On 27/01/14 22:21, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: >> I've at least identified two possible memory leaks in blkback, both >> related to the shutdown path of a VBD: >> >> - We don't wait for any pending purge work to finish before clean

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-27 Thread Konrad Rzeszutek Wilk
On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: > I've at least identified two possible memory leaks in blkback, both > related to the shutdown path of a VBD: > > - We don't wait for any pending purge work to finish before cleaning > the list of free_pages. The purge work will c

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-27 Thread Matt Wilson
On Mon, Jan 27, 2014 at 05:19:41PM +0100, Roger Pau Monné wrote: > On 27/01/14 17:09, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: > >> I've at least identified two possible memory leaks in blkback, both > >> related to the shutdown path of a VBD

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-27 Thread Roger Pau Monné
On 27/01/14 17:09, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: >> I've at least identified two possible memory leaks in blkback, both >> related to the shutdown path of a VBD: >> >> - We don't wait for any pending purge work to finish before clean

Re: [PATCH] xen-blkback: fix memory leaks

2014-01-27 Thread Konrad Rzeszutek Wilk
On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote: > I've at least identified two possible memory leaks in blkback, both > related to the shutdown path of a VBD: > > - We don't wait for any pending purge work to finish before cleaning > the list of free_pages. The purge work will c

[PATCH] xen-blkback: fix memory leaks

2014-01-27 Thread Roger Pau Monne
I've at least identified two possible memory leaks in blkback, both related to the shutdown path of a VBD: - We don't wait for any pending purge work to finish before cleaning the list of free_pages. The purge work will call put_free_pages and thus we might end up with pages being added to the