Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-11 Thread David Vrabel
On 11/08/14 13:31, Zoltan Kiss wrote: > On 08/08/14 17:33, Stephen Hemminger wrote: >> This idea of bouncing carrier is wrong. If guest is flow blocked you >> don't >> want to toggle carrier. That will cause problems because applications >> that are >> looking for carrier transistions like routing

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-11 Thread Zoltan Kiss
On 08/08/14 17:33, Stephen Hemminger wrote: This idea of bouncing carrier is wrong. If guest is flow blocked you don't want to toggle carrier. That will cause problems because applications that are looking for carrier transistions like routing daemons will be notified. If running a routing daemo

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-08 Thread Stephen Hemminger
This idea of bouncing carrier is wrong. If guest is flow blocked you don't want to toggle carrier. That will cause problems because applications that are looking for carrier transistions like routing daemons will be notified. If running a routing daemon this will also lead to link flapping which i

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread Zoltan Kiss
On 04/08/14 14:35, David Vrabel wrote: On 30/07/14 20:50, Zoltan Kiss wrote: Currently when the guest is not able to receive more packets, qdisc layer starts a timer, and when it goes off, qdisc is started again to deliver a packet again. This is a very slow way to drain the queues, consumes unn

Re: [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread Zoltan Kiss
On 01/08/14 11:52, Wei Liu wrote: On Wed, Jul 30, 2014 at 08:50:49PM +0100, Zoltan Kiss wrote: --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -176,9 +176,9 @@ struct xenvif_queue { /* Per-queue data for xenvif */ struct xen_netif_rx_back_ring rx;

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread David Vrabel
On 30/07/14 20:50, Zoltan Kiss wrote: > Currently when the guest is not able to receive more packets, qdisc layer > starts > a timer, and when it goes off, qdisc is started again to deliver a packet > again. > This is a very slow way to drain the queues, consumes unnecessary resources > and > sl

Re: [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-01 Thread Wei Liu
On Wed, Jul 30, 2014 at 08:50:49PM +0100, Zoltan Kiss wrote: > Currently when the guest is not able to receive more packets, qdisc layer > starts > a timer, and when it goes off, qdisc is started again to deliver a packet > again. > This is a very slow way to drain the queues, consumes unnecessar

Re: [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-07-31 Thread David Miller
From: Zoltan Kiss Date: Wed, 30 Jul 2014 20:50:49 +0100 > Currently when the guest is not able to receive more packets, qdisc layer > starts > a timer, and when it goes off, qdisc is started again to deliver a packet > again. > This is a very slow way to drain the queues, consumes unnecessary r

[PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-07-30 Thread Zoltan Kiss
Currently when the guest is not able to receive more packets, qdisc layer starts a timer, and when it goes off, qdisc is started again to deliver a packet again. This is a very slow way to drain the queues, consumes unnecessary resources and slows down other guests shutdown. This patch change the b