Re: [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-04 Thread Chentao (Boby)
Hi, Juergen. Thanks for your advice. I will send a v2 patch based on your suggested modifications. On 2015/3/3 17:52, Juergen Gross wrote: On 03/03/2015 09:37 AM, Tao Chen wrote: Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. I'm

Re: [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-04 Thread Chentao (Boby)
Hi, Juergen. Thanks for your advice. I will send a v2 patch based on your suggested modifications. On 2015/3/3 17:52, Juergen Gross wrote: On 03/03/2015 09:37 AM, Tao Chen wrote: Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. I'm

Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread David Vrabel
On 03/03/15 08:37, Tao Chen wrote: > Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, > it makes the code easier to read. You need to #define pr_fmt(fmt) to add a prefix like this. > struct ids_tuple v; /* translate from */ > - struct scsiback_tpg *tpg;

Re: [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread Juergen Gross
On 03/03/2015 09:37 AM, Tao Chen wrote: Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. I'm not really convinced this is worth a patch. OTOH I'm not completely against it. If nobody rejects this and all my further comments are addressed

[PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread Tao Chen
Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. Signed-off-by: Tao Chen --- drivers/xen/xen-scsiback.c | 67 +++--- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git

[PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread Tao Chen
Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. Signed-off-by: Tao Chen boby.c...@huawei.com --- drivers/xen/xen-scsiback.c | 67 +++--- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git

Re: [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread Juergen Gross
On 03/03/2015 09:37 AM, Tao Chen wrote: Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. I'm not really convinced this is worth a patch. OTOH I'm not completely against it. If nobody rejects this and all my further comments are addressed

Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread David Vrabel
On 03/03/15 08:37, Tao Chen wrote: Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX, it makes the code easier to read. You need to #define pr_fmt(fmt) to add a prefix like this. struct ids_tuple v; /* translate from */ - struct scsiback_tpg *tpg;