Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-06 Thread Arnd Bergmann
On Wed, May 6, 2020 at 7:12 AM Jürgen Groß wrote: > > On 05.05.20 22:57, Arnd Bergmann wrote: > > On Tue, May 5, 2020 at 6:02 PM Jürgen Groß wrote: > >> On 05.05.20 17:01, Arnd Bergmann wrote: > >>> On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: > On 05.05.20 16:15, Arnd Bergmann wrote:

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Jürgen Groß
On 05.05.20 22:57, Arnd Bergmann wrote: On Tue, May 5, 2020 at 6:02 PM Jürgen Groß wrote: On 05.05.20 17:01, Arnd Bergmann wrote: On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: On 05.05.20 16:15, Arnd Bergmann wrote: I considered that as well, and don't really mind either way. I think

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Arnd Bergmann
On Tue, May 5, 2020 at 6:02 PM Jürgen Groß wrote: > On 05.05.20 17:01, Arnd Bergmann wrote: > > On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: > >> On 05.05.20 16:15, Arnd Bergmann wrote: > > > > I considered that as well, and don't really mind either way. I think it does > > get a bit ugly

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Jürgen Groß
On 05.05.20 18:12, Boris Ostrovsky wrote: On 5/5/20 12:02 PM, Jürgen Groß wrote: On 05.05.20 17:01, Arnd Bergmann wrote: On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: On 05.05.20 16:15, Arnd Bergmann wrote: The __xenbus_map_ring() function has two large arrays, 'map' and 'unmap' on its

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Boris Ostrovsky
On 5/5/20 12:02 PM, Jürgen Groß wrote: > On 05.05.20 17:01, Arnd Bergmann wrote: >> On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: >>> On 05.05.20 16:15, Arnd Bergmann wrote: The __xenbus_map_ring() function has two large arrays, 'map' and 'unmap' on its stack. When clang decides

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Jürgen Groß
On 05.05.20 17:01, Arnd Bergmann wrote: On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: On 05.05.20 16:15, Arnd Bergmann wrote: The __xenbus_map_ring() function has two large arrays, 'map' and 'unmap' on its stack. When clang decides to inline it into its caller,

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Arnd Bergmann
On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: > On 05.05.20 16:15, Arnd Bergmann wrote: > > The __xenbus_map_ring() function has two large arrays, 'map' and > > 'unmap' on its stack. When clang decides to inline it into its caller, > > xenbus_map_ring_valloc_hvm(), the total stack usage

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Jürgen Groß
On 05.05.20 16:15, Arnd Bergmann wrote: The __xenbus_map_ring() function has two large arrays, 'map' and 'unmap' on its stack. When clang decides to inline it into its caller, xenbus_map_ring_valloc_hvm(), the total stack usage exceeds the warning limit for stack size on 32-bit architectures.

[PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Arnd Bergmann
The __xenbus_map_ring() function has two large arrays, 'map' and 'unmap' on its stack. When clang decides to inline it into its caller, xenbus_map_ring_valloc_hvm(), the total stack usage exceeds the warning limit for stack size on 32-bit architectures. drivers/xen/xenbus/xenbus_client.c:592:12: